Re: [PR] Add xxhash algorithms in SQL and expression api [datafusion]

2025-05-08 Thread via GitHub
Spaarsh commented on PR #14367: URL: https://github.com/apache/datafusion/pull/14367#issuecomment-2863419930 @alamb sure. I have my uni exams going on right now. That, along with some other commitments, might take me a while for porting these functions. If that is alright, then I'll be happ

Re: [PR] Add xxhash algorithms in SQL and expression api [datafusion]

2025-05-08 Thread via GitHub
alamb commented on PR #14367: URL: https://github.com/apache/datafusion/pull/14367#issuecomment-2863794206 Thanks @Spaarsh -- good luck with your examps -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Add xxhash algorithms in SQL and expression api [datafusion]

2025-05-05 Thread via GitHub
alamb commented on PR #14367: URL: https://github.com/apache/datafusion/pull/14367#issuecomment-2852189748 We recently added the datafusion-spark crate for spark compatible functions. @Spaarsh , would you be willing to port this function over to that crate and update it to be spark compatib

Re: [PR] Add xxhash algorithms in SQL and expression api [datafusion]

2025-04-30 Thread via GitHub
github-actions[bot] commented on PR #14367: URL: https://github.com/apache/datafusion/pull/14367#issuecomment-2843925031 Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or

Re: [PR] Add xxhash algorithms in SQL and expression api [datafusion]

2025-02-26 Thread via GitHub
alamb commented on PR #14367: URL: https://github.com/apache/datafusion/pull/14367#issuecomment-2685178672 That is all the more reason to perhaps defer to the spark function PR / focus on that -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Add xxhash algorithms in SQL and expression api [datafusion]

2025-02-26 Thread via GitHub
alamb commented on PR #14367: URL: https://github.com/apache/datafusion/pull/14367#issuecomment-2685178514 That is all the more reason to perhaps defer to the spark function PR / focus on that -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Add xxhash algorithms in SQL and expression api [datafusion]

2025-02-25 Thread via GitHub
Omega359 commented on PR #14367: URL: https://github.com/apache/datafusion/pull/14367#issuecomment-2683366217 Note that this seems to also be in the spark function PR - https://github.com/apache/datafusion/pull/14392/files#diff-2bbff2d3a0ce9cec9ed9d6ec6e38ff910875af704b60855f43b47b46c96c5d44

Re: [PR] Add xxhash algorithms in SQL and expression api [datafusion]

2025-02-10 Thread via GitHub
alamb commented on PR #14367: URL: https://github.com/apache/datafusion/pull/14367#issuecomment-2648336196 So unless there are many users (and ideally maintainers) of new functions, I am hesitant to add new ones -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] Add xxhash algorithms in SQL and expression api [datafusion]

2025-02-10 Thread via GitHub
alamb commented on PR #14367: URL: https://github.com/apache/datafusion/pull/14367#issuecomment-2648334436 > @alamb could you also get a clarification over the inclusion of wyhash functions as well? It was also requested under the same issue [here](https://github.com/apache/datafusion/issue

Re: [PR] Add xxhash algorithms in SQL and expression api [datafusion]

2025-02-10 Thread via GitHub
Spaarsh commented on PR #14367: URL: https://github.com/apache/datafusion/pull/14367#issuecomment-2648257379 @alamb could you also get a clarification over the inclusion of wyhash functions as well? It was also requested under the same issue [here](https://github.com/apache/datafusion/issue