Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on PR #12116: URL: https://github.com/apache/datafusion/pull/12116#issuecomment-2661146353 Many thanks @jayzhan211 @samuelcolvin @Omega359 @alamb :pray: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Add union_extract scalar function [datafusion]

alamb commented on PR #12116: URL: https://github.com/apache/datafusion/pull/12116#issuecomment-2659540056 This PR caused a CI failure on main (due to a logical conflict). Small PR to fix: - https://github.com/apache/datafusion/pull/14667 -- This is an automated message from the Apach

Re: [PR] Add union_extract scalar function [datafusion]

alamb merged PR #12116: URL: https://github.com/apache/datafusion/pull/12116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Add union_extract scalar function [datafusion]

alamb commented on PR #12116: URL: https://github.com/apache/datafusion/pull/12116#issuecomment-2659498648 Thanks again @gstvg @jayzhan211 and @Omega359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Add union_extract scalar function [datafusion]

alamb commented on PR #12116: URL: https://github.com/apache/datafusion/pull/12116#issuecomment-2656193648 It is exciting to get better union support as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Add union_extract scalar function [datafusion]

Omega359 commented on PR #12116: URL: https://github.com/apache/datafusion/pull/12116#issuecomment-2655362249 @alamb should be, yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Add union_extract scalar function [datafusion]

alamb commented on PR #12116: URL: https://github.com/apache/datafusion/pull/12116#issuecomment-2655006559 What is the status of this PR? Is is ready for a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1947939409 ## datafusion/expr/src/udf.rs: ## @@ -951,4 +952,10 @@ The following regular expression functions are supported:"#, label: "Other Functions", desc

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1947937272 ## datafusion/functions/src/core/union_extract.rs: ## @@ -0,0 +1,260 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licens

Re: [PR] Add union_extract scalar function [datafusion]

Omega359 commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1946472535 ## datafusion/functions/src/core/union_extract.rs: ## @@ -0,0 +1,260 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lic

Re: [PR] Add union_extract scalar function [datafusion]

Omega359 commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1946471266 ## datafusion/expr/src/udf.rs: ## @@ -951,4 +952,10 @@ The following regular expression functions are supported:"#, label: "Other Functions", d

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on PR #12116: URL: https://github.com/apache/datafusion/pull/12116#issuecomment-2601470429 Thanks @jayzhan211 🙏, this is ready for review cc @tobixdev -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on PR #12116: URL: https://github.com/apache/datafusion/pull/12116#issuecomment-2601112958 Hi @jayzhan211, can you reopen this, or should I open a new PR? Sorry for the delay. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Add union_extract scalar function [datafusion]

github-actions[bot] closed pull request #12116: Add union_extract scalar function URL: https://github.com/apache/datafusion/pull/12116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Add union_extract scalar function [datafusion]

github-actions[bot] commented on PR #12116: URL: https://github.com/apache/datafusion/pull/12116#issuecomment-2469435968 Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1757226342 ## datafusion/functions/src/core/union_extract.rs: ## @@ -0,0 +1,722 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licens

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1757226342 ## datafusion/functions/src/core/union_extract.rs: ## @@ -0,0 +1,722 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licens

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1757226342 ## datafusion/functions/src/core/union_extract.rs: ## @@ -0,0 +1,722 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licens

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1757194244 ## datafusion/sqllogictest/test_files/union_datatype.slt: ## @@ -0,0 +1,255 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: Look

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1757193466 ## datafusion/functions/src/core/union_extract.rs: ## @@ -0,0 +1,722 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licens

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1757193028 ## datafusion/functions/src/core/union_extract.rs: ## @@ -0,0 +1,722 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licens

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1755879897 ## datafusion/functions/benches/union_extract.rs: ## @@ -0,0 +1,1121 @@ +#[macro_use] +extern crate criterion; + +use crate::criterion::Criterion; +use arrow::{ +

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1755878566 ## datafusion/functions/src/core/union_extract.rs: ## @@ -0,0 +1,722 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licens

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1755877101 ## datafusion/functions/src/core/union_extract.rs: ## @@ -0,0 +1,722 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licens

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1755876225 ## datafusion/sqllogictest/src/test_context.rs: ## @@ -361,3 +369,893 @@ fn create_example_udf() -> ScalarUDF { adder, ) } + +fn register_union_tables

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1755875475 ## datafusion/functions/src/core/union_extract.rs: ## @@ -0,0 +1,722 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licens

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on PR #12116: URL: https://github.com/apache/datafusion/pull/12116#issuecomment-2344991858 Thanks @samuelcolvin and @jayzhan211 for your reviews. I moved part of this PR to https://github.com/apache/arrow-rs/pull/6387. I made all your requests that were applicable there, an

Re: [PR] Add union_extract scalar function [datafusion]

jayzhan211 commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1731981156 ## datafusion/functions/src/core/union_extract.rs: ## @@ -0,0 +1,722 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor l

Re: [PR] Add union_extract scalar function [datafusion]

jayzhan211 commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1731980126 ## datafusion/functions/src/core/union_extract.rs: ## @@ -0,0 +1,722 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor l

Re: [PR] Add union_extract scalar function [datafusion]

jayzhan211 commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1731979504 ## datafusion/functions/src/core/union_extract.rs: ## @@ -0,0 +1,722 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor l

Re: [PR] Add union_extract scalar function [datafusion]

jayzhan211 commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1731979504 ## datafusion/functions/src/core/union_extract.rs: ## @@ -0,0 +1,722 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor l

Re: [PR] Add union_extract scalar function [datafusion]

jayzhan211 commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1731979153 ## datafusion/functions/benches/union_extract.rs: ## @@ -0,0 +1,1121 @@ +#[macro_use] +extern crate criterion; + +use crate::criterion::Criterion; +use arrow::{

Re: [PR] Add union_extract scalar function [datafusion]

jayzhan211 commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1731976320 ## datafusion/sqllogictest/src/test_context.rs: ## @@ -361,3 +369,893 @@ fn create_example_udf() -> ScalarUDF { adder, ) } + +fn register_union_t

Re: [PR] Add union_extract scalar function [datafusion]

jayzhan211 commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1731975403 ## datafusion/sqllogictest/test_files/union_datatype.slt: ## @@ -0,0 +1,255 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment:

Re: [PR] Add union_extract scalar function [datafusion]

jayzhan211 commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1731975403 ## datafusion/sqllogictest/test_files/union_datatype.slt: ## @@ -0,0 +1,255 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment:

Re: [PR] Add union_extract scalar function [datafusion]

jayzhan211 commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1731970698 ## datafusion/functions/src/core/union_extract.rs: ## @@ -0,0 +1,722 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor l

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1729378926 ## datafusion/functions/src/core/union_extract.rs: ## @@ -0,0 +1,722 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licens

Re: [PR] Add union_extract scalar function [datafusion]

samuelcolvin commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1729195750 ## datafusion/functions/src/core/union_extract.rs: ## @@ -0,0 +1,722 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1727611010 ## datafusion/functions/benches/union_extract.rs: ## @@ -0,0 +1,1121 @@ +#[macro_use] +extern crate criterion; + +use crate::criterion::Criterion; +use arrow::{ +

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1727614121 ## datafusion/sqllogictest/src/test_context.rs: ## @@ -361,3 +369,893 @@ fn create_example_udf() -> ScalarUDF { adder, ) } + +fn register_union_tables

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1727611010 ## datafusion/functions/benches/union_extract.rs: ## @@ -0,0 +1,1121 @@ +#[macro_use] +extern crate criterion; + +use crate::criterion::Criterion; +use arrow::{ +

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1727611010 ## datafusion/functions/benches/union_extract.rs: ## @@ -0,0 +1,1121 @@ +#[macro_use] +extern crate criterion; + +use crate::criterion::Criterion; +use arrow::{ +

Re: [PR] Add union_extract scalar function [datafusion]

gstvg commented on code in PR #12116: URL: https://github.com/apache/datafusion/pull/12116#discussion_r1727606208 ## datafusion/functions/src/core/union_extract.rs: ## @@ -0,0 +1,722 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licens