Re: [PR] Add support for MS Varbinary(MAX) (#1714) [datafusion-sqlparser-rs]

2025-02-13 Thread via GitHub
alamb commented on PR #1715: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1715#issuecomment-2656189253 > @alamb Anything else I need to address? I'm learning the standard Rust way of doing things, hoping I got it right based on the PR checks in place. Nope -- sorry for

Re: [PR] Add support for MS Varbinary(MAX) (#1714) [datafusion-sqlparser-rs]

2025-02-13 Thread via GitHub
alamb merged PR #1715: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr.

Re: [PR] Add support for MS Varbinary(MAX) (#1714) [datafusion-sqlparser-rs]

2025-02-12 Thread via GitHub
TylerBrinks commented on PR #1715: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1715#issuecomment-2655131625 @alamb Anything else I need to address? I'm learning the standard Rust way of doing things, hoping I got it right based on the PR checks in place. -- This is an au

Re: [PR] Add support for MS Varbinary(MAX) (#1714) [datafusion-sqlparser-rs]

2025-02-10 Thread via GitHub
TylerBrinks commented on PR #1715: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1715#issuecomment-2649495366 I think I got it right in the updated most recent push. Awaiting approval if it passes the criteria. -- This is an automated message from the Apache Git Service. T

Re: [PR] Add support for MS Varbinary(MAX) (#1714) [datafusion-sqlparser-rs]

2025-02-07 Thread via GitHub
alamb commented on PR #1715: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1715#issuecomment-2643662849 > a C# port of this library. Very cool! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the