alamb commented on PR #13310:
URL: https://github.com/apache/datafusion/pull/13310#issuecomment-2559754026
BTW we have been having problems downstream wiht the new recursive / stacker
dependency. See for example:
- https://github.com/apache/datafusion/issues/13513
- https://github.com/
peter-toth commented on PR #13310:
URL: https://github.com/apache/datafusion/pull/13310#issuecomment-2470083951
Thanks for the review @blaginin, @comphead, @alamb!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
comphead merged PR #13310:
URL: https://github.com/apache/datafusion/pull/13310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead commented on code in PR #13310:
URL: https://github.com/apache/datafusion/pull/13310#discussion_r1837021081
##
datafusion/sql/src/query.rs:
##
@@ -59,8 +59,9 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
self.select_into(plan, select_into)
peter-toth commented on code in PR #13310:
URL: https://github.com/apache/datafusion/pull/13310#discussion_r1836813902
##
datafusion/sql/src/query.rs:
##
@@ -59,7 +59,12 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
self.select_into(plan, select_into)
peter-toth commented on code in PR #13310:
URL: https://github.com/apache/datafusion/pull/13310#discussion_r1836813902
##
datafusion/sql/src/query.rs:
##
@@ -59,7 +59,12 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
self.select_into(plan, select_into)
peter-toth commented on code in PR #13310:
URL: https://github.com/apache/datafusion/pull/13310#discussion_r1836836706
##
datafusion/sql/src/query.rs:
##
@@ -59,7 +59,12 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
self.select_into(plan, select_into)
peter-toth commented on code in PR #13310:
URL: https://github.com/apache/datafusion/pull/13310#discussion_r1836813902
##
datafusion/sql/src/query.rs:
##
@@ -59,7 +59,12 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
self.select_into(plan, select_into)
peter-toth commented on code in PR #13310:
URL: https://github.com/apache/datafusion/pull/13310#discussion_r1836819378
##
datafusion/sql/src/expr/mod.rs:
##
@@ -168,6 +169,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
/// Internal implementation. Use
/// [`Self
peter-toth commented on code in PR #13310:
URL: https://github.com/apache/datafusion/pull/13310#discussion_r1836813902
##
datafusion/sql/src/query.rs:
##
@@ -59,7 +59,12 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
self.select_into(plan, select_into)
blaginin commented on code in PR #13310:
URL: https://github.com/apache/datafusion/pull/13310#discussion_r1835437834
##
datafusion/sql/src/expr/mod.rs:
##
@@ -168,6 +169,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
/// Internal implementation. Use
/// [`Self::
peter-toth commented on PR #13310:
URL: https://github.com/apache/datafusion/pull/13310#issuecomment-2465253939
> Wondering if the compiler or runtime can optimize the code now knowing the
method is recursive.
>
> LIke https://www.scala-lang.org/api/3.1.1/scala/annotation/tailrec.html
peter-toth commented on code in PR #13310:
URL: https://github.com/apache/datafusion/pull/13310#discussion_r1834704084
##
datafusion/sql/src/query.rs:
##
@@ -59,7 +59,12 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
self.select_into(plan, select_into)
blaginin commented on code in PR #13310:
URL: https://github.com/apache/datafusion/pull/13310#discussion_r1834639511
##
datafusion/sql/src/query.rs:
##
@@ -59,7 +59,12 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
self.select_into(plan, select_into)
comphead commented on code in PR #13310:
URL: https://github.com/apache/datafusion/pull/13310#discussion_r1834636921
##
datafusion/sql/src/query.rs:
##
@@ -59,7 +59,12 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
self.select_into(plan, select_into)
peter-toth commented on PR #13310:
URL: https://github.com/apache/datafusion/pull/13310#issuecomment-2464821335
Cherry-picked the test from your
https://github.com/apache/datafusion/pull/13177 if you don't mind:
https://github.com/apache/datafusion/pull/13310/commits/c42668bdd349fc1ef6ca588
blaginin commented on PR #13310:
URL: https://github.com/apache/datafusion/pull/13310#issuecomment-2464746688
Do you also want to add a test with some large tree?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
17 matches
Mail list logo
