SKY-ALIN closed pull request #14282: Add regexp_extract func
URL: https://github.com/apache/datafusion/pull/14282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
Omega359 commented on PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#issuecomment-2773275754
I spent some time today looking at this PR. Here are my thoughts:
- This udf closely mirrors the
[duckdb](https://duckdb.org/docs/stable/sql/functions/regular_expressions.html
Omega359 commented on PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#issuecomment-2772580217
I'll take a look at this later today @SKY-ALIN
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
SKY-ALIN commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r2012956967
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,322 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
Omega359 commented on PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#issuecomment-2743165457
@SKY-ALIN - are you able to look into the above review comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
rluvaton commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1981449667
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,322 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
Omega359 commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1938507496
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,322 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
rluvaton commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1938303236
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,322 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
rluvaton commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1938301064
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
SKY-ALIN commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1937604422
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
SKY-ALIN commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1937745027
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
SKY-ALIN commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1937744642
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
SKY-ALIN commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1937744088
##
docs/source/user-guide/sql/scalar_functions.md:
##
@@ -1919,6 +1920,31 @@ SELECT regexp_replace('aBc', '(b|d)', 'Ab\\1a', 'i');
Additional examples can be f
SKY-ALIN commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1937604422
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
rluvaton commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1932896635
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
rluvaton commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1932901931
##
docs/source/user-guide/sql/scalar_functions.md:
##
@@ -1919,6 +1920,31 @@ SELECT regexp_replace('aBc', '(b|d)', 'Ab\\1a', 'i');
Additional examples can be f
rluvaton commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1932904240
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
rluvaton commented on PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#issuecomment-2620107324
FYI Spark regex is not the same as Rust regex and can have different results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
alamb commented on PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#issuecomment-2616949171
FYI @Omega359 noted this is quite similar to
- https://github.com/apache/datafusion/pull/14323
--
This is an automated message from the Apache Git Service.
To respond to the mess
Omega359 commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1929809676
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
SKY-ALIN commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1929597131
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
SKY-ALIN commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1929596877
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
SKY-ALIN commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1929596970
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
SKY-ALIN commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1929596852
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
Omega359 commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1929541426
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
Omega359 commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1929541028
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
Omega359 commented on PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#issuecomment-2613964912
Thanks for your contribution! I've left some comments for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
Omega359 commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1929541738
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
Omega359 commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1929540823
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
29 matches
Mail list logo
