github-actions[bot] closed pull request #14297: Add nulls checks to generated
pruning predicates
URL: https://github.com/apache/datafusion/pull/14297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on PR #14297:
URL: https://github.com/apache/datafusion/pull/14297#issuecomment-2788100319
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
alamb commented on PR #14297:
URL: https://github.com/apache/datafusion/pull/14297#issuecomment-2640833744
Marking as draft as I think this PR is no longer waiting on feedback. Please
mark it as ready for review when it is ready for another look
--
This is an automated message from the A
alamb commented on code in PR #14297:
URL: https://github.com/apache/datafusion/pull/14297#discussion_r1938285557
##
datafusion/physical-optimizer/src/pruning.rs:
##
@@ -287,11 +285,6 @@ pub trait PruningStatistics {
/// predicate can never possibly be true). The container ca
appletreeisyellow commented on code in PR #14297:
URL: https://github.com/apache/datafusion/pull/14297#discussion_r1938185973
##
datafusion/physical-optimizer/src/pruning.rs:
##
@@ -819,16 +813,24 @@ impl RequiredColumns {
/// statistics column, while keeping track that a r
appletreeisyellow commented on PR #14297:
URL: https://github.com/apache/datafusion/pull/14297#issuecomment-2625521692
@adriangb @alamb The PR description makes sense to me. I plan to give it a
deeper review either later today or tomorrow
--
This is an automated message from the Apache Gi
alamb commented on PR #14297:
URL: https://github.com/apache/datafusion/pull/14297#issuecomment-2625224691
This one one in particular I think needs some serious thinking to make sure
it is correct. Perhaps @appletreeisyellow has some time and interest to help
out reviewing
--
This is an
adriangb commented on PR #14297:
URL: https://github.com/apache/datafusion/pull/14297#issuecomment-2616977356
Totally understood. No rush on this. I will look through PRs and see if I
can help with any.
--
This is an automated message from the Apache Git Service.
To respond to the message
alamb commented on PR #14297:
URL: https://github.com/apache/datafusion/pull/14297#issuecomment-2616962805
I see this -- it makes sense to me. I am interested in helping mover it
along, but there are currently a lot of PRs backed up on review. Any chance you
want to help get some of them re
adriangb commented on PR #14297:
URL: https://github.com/apache/datafusion/pull/14297#issuecomment-2614084411
@alamb any appetite for us to move forward with this? I must admit that it
is something that would _greatly_ help us internally, but I did try to lay out
a case above for why it mig
adriangb commented on code in PR #14297:
URL: https://github.com/apache/datafusion/pull/14297#discussion_r1929591473
##
datafusion/physical-optimizer/src/pruning.rs:
##
@@ -819,16 +813,24 @@ impl RequiredColumns {
/// statistics column, while keeping track that a reference
11 matches
Mail list logo
