github-actions[bot] closed pull request #12523: Add hook for sharing join state
in distributed execution
URL: https://github.com/apache/datafusion/pull/12523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
github-actions[bot] commented on PR #12523:
URL: https://github.com/apache/datafusion/pull/12523#issuecomment-2972121947
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
github-actions[bot] closed pull request #12523: Add hook for sharing join state
in distributed execution
URL: https://github.com/apache/datafusion/pull/12523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
github-actions[bot] commented on PR #12523:
URL: https://github.com/apache/datafusion/pull/12523#issuecomment-2764926021
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
github-actions[bot] closed pull request #12523: Add hook for sharing join state
in distributed execution
URL: https://github.com/apache/datafusion/pull/12523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
github-actions[bot] commented on PR #12523:
URL: https://github.com/apache/datafusion/pull/12523#issuecomment-2601169692
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
github-actions[bot] commented on PR #12523:
URL: https://github.com/apache/datafusion/pull/12523#issuecomment-2487163766
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
thinkharderdev commented on PR #12523:
URL: https://github.com/apache/datafusion/pull/12523#issuecomment-2364578331
> Maybe its easier to build some diagram in draw.io or something? I got the
point about shared state but I'm not sure how it will be travelling from caller
side and to caller
thinkharderdev commented on code in PR #12523:
URL: https://github.com/apache/datafusion/pull/12523#discussion_r1769224360
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -71,11 +71,68 @@ use datafusion_physical_expr::equivalence::{
use datafusion_physical_expr::Physi
thinkharderdev commented on code in PR #12523:
URL: https://github.com/apache/datafusion/pull/12523#discussion_r1769224022
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -71,11 +71,68 @@ use datafusion_physical_expr::equivalence::{
use datafusion_physical_expr::Physi
thinkharderdev commented on code in PR #12523:
URL: https://github.com/apache/datafusion/pull/12523#discussion_r1769221343
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -131,8 +192,29 @@ impl JoinLeftData {
/// Decrements the counter of running threads, and retu
comphead commented on PR #12523:
URL: https://github.com/apache/datafusion/pull/12523#issuecomment-2364397811
Maybe its easier to build some diagram in draw.io or something?
I got the point about shared state but I'm not sure how it will be
travelling from caller side and to caller side
comphead commented on code in PR #12523:
URL: https://github.com/apache/datafusion/pull/12523#discussion_r1769078580
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -131,8 +192,29 @@ impl JoinLeftData {
/// Decrements the counter of running threads, and returns `t
comphead commented on code in PR #12523:
URL: https://github.com/apache/datafusion/pull/12523#discussion_r1769076385
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -71,11 +71,68 @@ use datafusion_physical_expr::equivalence::{
use datafusion_physical_expr::PhysicalExp
comphead commented on code in PR #12523:
URL: https://github.com/apache/datafusion/pull/12523#discussion_r1769075068
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -71,11 +71,68 @@ use datafusion_physical_expr::equivalence::{
use datafusion_physical_expr::PhysicalExp
comphead commented on PR #12523:
URL: https://github.com/apache/datafusion/pull/12523#issuecomment-2364357186
@korowa FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
thinkharderdev commented on code in PR #12523:
URL: https://github.com/apache/datafusion/pull/12523#discussion_r1765125127
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -2224,6 +2354,179 @@ mod tests {
assert_batches_sorted_eq!(expected, &batches);
}
thinkharderdev commented on code in PR #12523:
URL: https://github.com/apache/datafusion/pull/12523#discussion_r1765123819
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -1466,18 +1562,35 @@ impl HashJoinStream {
/// Updates state to `Completed`
fn process_u
thinkharderdev commented on code in PR #12523:
URL: https://github.com/apache/datafusion/pull/12523#discussion_r1765122554
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -688,11 +770,21 @@ impl ExecutionPlan for HashJoinExec {
);
}
+let
thinkharderdev commented on PR #12523:
URL: https://github.com/apache/datafusion/pull/12523#issuecomment-2358557669
Set as draft for now as I still need to integrate into
`NestedLoopJoinStream` but the basic approach is all here
--
This is an automated message from the Apache Git Service
20 matches
Mail list logo
