Re: [PR] Add DataFrame fill_null [datafusion]

comphead merged PR #14769: URL: https://github.com/apache/datafusion/pull/14769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@dataf

Re: [PR] Add DataFrame fill_null [datafusion]

comphead commented on PR #14769: URL: https://github.com/apache/datafusion/pull/14769#issuecomment-2685536375 @Omega359 do you think we can proceed with the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Add DataFrame fill_null [datafusion]

Omega359 commented on PR #14769: URL: https://github.com/apache/datafusion/pull/14769#issuecomment-2685553518 > @Omega359 do you think we can proceed with the PR? Yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Add DataFrame fill_null [datafusion]

Omega359 commented on PR #14769: URL: https://github.com/apache/datafusion/pull/14769#issuecomment-2683368595 I did a quick check in the spark functions PR, I didn't see anything related to fill. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Add DataFrame fill_null [datafusion]

comphead commented on PR #14769: URL: https://github.com/apache/datafusion/pull/14769#issuecomment-2683472594 > > > I did a quick check in the spark functions PR, I didn't see anything related to fill. > > > > > > hi @Omega359 are you referring to https://spark.apache.org/docs/3.

Re: [PR] Add DataFrame fill_null [datafusion]

Omega359 commented on PR #14769: URL: https://github.com/apache/datafusion/pull/14769#issuecomment-2683448966 > > I did a quick check in the spark functions PR, I didn't see anything related to fill. > > hi @Omega359 are you referring to https://spark.apache.org/docs/3.5.4/api/java/o

Re: [PR] Add DataFrame fill_null [datafusion]

comphead commented on PR #14769: URL: https://github.com/apache/datafusion/pull/14769#issuecomment-2683379630 > I did a quick check in the spark functions PR, I didn't see anything related to fill. hi @Omega359 are you referring to https://spark.apache.org/docs/3.5.4/api/java/org/apa

Re: [PR] Add DataFrame fill_null [datafusion]

alamb commented on PR #14769: URL: https://github.com/apache/datafusion/pull/14769#issuecomment-2683332509 FWI @Omega359 and @timsaucer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Add DataFrame fill_null [datafusion]

comphead commented on code in PR #14769: URL: https://github.com/apache/datafusion/pull/14769#discussion_r1969975612 ## datafusion/core/src/dataframe/mod.rs: ## @@ -1926,6 +1930,71 @@ impl DataFrame { plan, }) } + +/// Fill null values in specified

Re: [PR] Add DataFrame fill_null [datafusion]

kosiew commented on code in PR #14769: URL: https://github.com/apache/datafusion/pull/14769#discussion_r1967089979 ## datafusion/core/src/dataframe/mod.rs: ## @@ -1926,6 +1930,71 @@ impl DataFrame { plan, }) } + +/// Fill null values in specified c

Re: [PR] Add DataFrame fill_null [datafusion]

kosiew commented on PR #14769: URL: https://github.com/apache/datafusion/pull/14769#issuecomment-2680284864 > its documented in https://docs.rs/datafusion/latest/datafusion/dataframe/struct.DataFrame.html not in the code itself I added fill_null example usage in dataframe/mod.rs for

Re: [PR] Add DataFrame fill_null [datafusion]

kosiew commented on code in PR #14769: URL: https://github.com/apache/datafusion/pull/14769#discussion_r1968745726 ## datafusion/core/src/dataframe/mod.rs: ## @@ -1926,6 +1930,71 @@ impl DataFrame { plan, }) } + +/// Fill null values in specified c

Re: [PR] Add DataFrame fill_null [datafusion]

kosiew commented on code in PR #14769: URL: https://github.com/apache/datafusion/pull/14769#discussion_r1968745726 ## datafusion/core/src/dataframe/mod.rs: ## @@ -1926,6 +1930,71 @@ impl DataFrame { plan, }) } + +/// Fill null values in specified c

Re: [PR] Add DataFrame fill_null [datafusion]

kosiew commented on code in PR #14769: URL: https://github.com/apache/datafusion/pull/14769#discussion_r1967089979 ## datafusion/core/src/dataframe/mod.rs: ## @@ -1926,6 +1930,71 @@ impl DataFrame { plan, }) } + +/// Fill null values in specified c

Re: [PR] Add DataFrame fill_null [datafusion]

kosiew commented on code in PR #14769: URL: https://github.com/apache/datafusion/pull/14769#discussion_r1967089979 ## datafusion/core/src/dataframe/mod.rs: ## @@ -1926,6 +1930,71 @@ impl DataFrame { plan, }) } + +/// Fill null values in specified c

Re: [PR] Add DataFrame fill_null [datafusion]

comphead commented on code in PR #14769: URL: https://github.com/apache/datafusion/pull/14769#discussion_r1965693790 ## datafusion/core/src/dataframe/mod.rs: ## @@ -1926,6 +1930,71 @@ impl DataFrame { plan, }) } + +/// Fill null values in specified

Re: [PR] Add DataFrame fill_null [datafusion]

comphead commented on PR #14769: URL: https://github.com/apache/datafusion/pull/14769#issuecomment-2674922087 > Thanks @kosiew looks great some minor comments > > I'm surprised though we dont have a documentation with DataFrame API its documented in https://docs.rs/datafusion/l

Re: [PR] Add DataFrame fill_null [datafusion]

comphead commented on code in PR #14769: URL: https://github.com/apache/datafusion/pull/14769#discussion_r1965698780 ## datafusion/core/src/dataframe/mod.rs: ## @@ -1926,6 +1930,71 @@ impl DataFrame { plan, }) } + +/// Fill null values in specified

Re: [PR] Add DataFrame fill_null [datafusion]

comphead commented on code in PR #14769: URL: https://github.com/apache/datafusion/pull/14769#discussion_r1965696512 ## datafusion/core/src/dataframe/mod.rs: ## @@ -1926,6 +1930,71 @@ impl DataFrame { plan, }) } + +/// Fill null values in specified