iffyio merged PR #1810:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
aharpervc commented on code in PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#discussion_r2071819600
##
src/dialect/mssql.rs:
##
@@ -215,6 +225,59 @@ impl MsSqlDialect {
}))
}
+/// Parse `CREATE TRIGGER` for [MsSql]
+///
+
aharpervc commented on code in PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#discussion_r2071762118
##
src/dialect/mssql.rs:
##
@@ -215,6 +225,59 @@ impl MsSqlDialect {
}))
}
+/// Parse `CREATE TRIGGER` for [MsSql]
+///
+
aharpervc commented on code in PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#discussion_r2071734824
##
src/dialect/mssql.rs:
##
@@ -215,6 +225,59 @@ impl MsSqlDialect {
}))
}
+/// Parse `CREATE TRIGGER` for [MsSql]
+///
+
iffyio commented on code in PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#discussion_r2071038220
##
src/dialect/mssql.rs:
##
@@ -215,6 +225,59 @@ impl MsSqlDialect {
}))
}
+/// Parse `CREATE TRIGGER` for [MsSql]
+///
+///
aharpervc commented on code in PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#discussion_r2070337010
##
src/dialect/mssql.rs:
##
@@ -215,6 +225,59 @@ impl MsSqlDialect {
}))
}
+/// Parse `CREATE TRIGGER` for [MsSql]
+///
+
aharpervc commented on code in PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#discussion_r2068747275
##
src/dialect/mssql.rs:
##
@@ -215,6 +218,78 @@ impl MsSqlDialect {
}))
}
+/// Parse a SQL CREATE statement
+fn parse_create
aharpervc commented on code in PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#discussion_r2068726100
##
src/dialect/mssql.rs:
##
@@ -215,6 +218,78 @@ impl MsSqlDialect {
}))
}
+/// Parse a SQL CREATE statement
+fn parse_create
aharpervc commented on code in PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#discussion_r2068726100
##
src/dialect/mssql.rs:
##
@@ -215,6 +218,78 @@ impl MsSqlDialect {
}))
}
+/// Parse a SQL CREATE statement
+fn parse_create
iffyio commented on code in PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#discussion_r2067861834
##
src/dialect/mssql.rs:
##
@@ -215,6 +218,78 @@ impl MsSqlDialect {
}))
}
+/// Parse a SQL CREATE statement
+fn parse_create(&s
aharpervc commented on code in PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#discussion_r2067492348
##
src/dialect/mssql.rs:
##
@@ -215,6 +218,78 @@ impl MsSqlDialect {
}))
}
+/// Parse a SQL CREATE statement
+fn parse_create
iffyio commented on code in PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#discussion_r2067388595
##
src/dialect/mssql.rs:
##
@@ -215,6 +218,78 @@ impl MsSqlDialect {
}))
}
+/// Parse a SQL CREATE statement
+fn parse_create(&s
aharpervc commented on code in PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#discussion_r2067364403
##
src/parser/mod.rs:
##
@@ -5256,14 +5256,19 @@ impl<'a> Parser<'a> {
pub fn parse_create_trigger(
&mut self,
+or_alter: boo
iffyio commented on code in PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#discussion_r2067197344
##
src/parser/mod.rs:
##
@@ -5256,14 +5256,19 @@ impl<'a> Parser<'a> {
pub fn parse_create_trigger(
&mut self,
+or_alter: bool,
iffyio commented on code in PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#discussion_r2067198693
##
src/parser/mod.rs:
##
@@ -5256,14 +5256,19 @@ impl<'a> Parser<'a> {
pub fn parse_create_trigger(
&mut self,
+or_alter: bool,
iffyio commented on code in PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#discussion_r2067197344
##
src/parser/mod.rs:
##
@@ -5256,14 +5256,19 @@ impl<'a> Parser<'a> {
pub fn parse_create_trigger(
&mut self,
+or_alter: bool,
aharpervc commented on code in PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#discussion_r2063813313
##
src/parser/mod.rs:
##
@@ -5256,14 +5256,19 @@ impl<'a> Parser<'a> {
pub fn parse_create_trigger(
&mut self,
+or_alter: boo
iffyio commented on code in PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#discussion_r2061190816
##
src/parser/mod.rs:
##
@@ -5256,14 +5256,19 @@ impl<'a> Parser<'a> {
pub fn parse_create_trigger(
&mut self,
+or_alter: bool,
aharpervc commented on PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#issuecomment-2825353800
Rebased again now that
https://github.com/apache/datafusion-sqlparser-rs/pull/1808 has been merged.
Should be ready for review.
--
This is an automated message from
aharpervc commented on PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#issuecomment-2802226543
FYI for reviewers I rebased this on the create function branch, due to the
return statement logic here:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#disc
aharpervc commented on PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#issuecomment-2802223801
This fails to parse on this branch, but should:
```mssql
CREATE TRIGGER some_trigger ON some_table FOR INSERT
AS
BEGIN
IF 1=1
BEGIN
aharpervc commented on code in PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#discussion_r2040246620
##
src/parser/mod.rs:
##
@@ -5265,18 +5271,71 @@ impl<'a> Parser<'a> {
trigger_object,
include_each,
condition
22 matches
Mail list logo
