ByteBaker commented on issue #13037:
URL: https://github.com/apache/datafusion/issues/13037#issuecomment-2773191102
@alamb @buraksenn I think that would be me, since I made the call to go with
array literals than `vec![]` since the former avoids allocation. But now that I
see it, should I m
alamb commented on issue #13037:
URL: https://github.com/apache/datafusion/issues/13037#issuecomment-2776834231
Thanks @ByteBaker -- I don't have any strong opinion / advice here
unfortunately
--
This is an automated message from the Apache Git Service.
To respond to the message, please
alamb commented on issue #13037:
URL: https://github.com/apache/datafusion/issues/13037#issuecomment-2544099137
Thanks for looking at this @buraksenn
I thought we more or less ported the macro from DataFusion to Arrow so the
different is surprising, but I haven't had a chance to look
buraksenn commented on issue #13037:
URL: https://github.com/apache/datafusion/issues/13037#issuecomment-2543312794
I've took another look into this and tried to change it but the issue is
that macro in arrow only accepts array literals such as:
[1,2,3]. However, in the datafusion macro i
buraksenn commented on issue #13037:
URL: https://github.com/apache/datafusion/issues/13037#issuecomment-2527809229
> > Should this be done? I saw this #12846. I can delete create_array and
record_batch macros to make it use the same as in arrow. Also they are also not
identical:
> >
alamb commented on issue #13037:
URL: https://github.com/apache/datafusion/issues/13037#issuecomment-2527749169
> Should this be done? I saw this #12846. I can delete create_array and
record_batch macros to make it use the same as in arrow. Also they are also not
identical:
>
> * Dat
buraksenn commented on issue #13037:
URL: https://github.com/apache/datafusion/issues/13037#issuecomment-2526291502
Should this be done? I saw this
https://github.com/apache/datafusion/pull/12846. I can delete create_array and
record_batch macros to make it use the same as in arrow. Also th
timsaucer commented on issue #13037:
URL: https://github.com/apache/datafusion/issues/13037#issuecomment-2428803455
Sounds great! It will probably take a while as we have to wait for the
upstream to make a release, and then DF to update to that release version.
--
This is an automated mes
buraksenn commented on issue #13037:
URL: https://github.com/apache/datafusion/issues/13037#issuecomment-2428505334
I will keep an eye on the update and do the required change if it is okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
buraksenn commented on issue #13037:
URL: https://github.com/apache/datafusion/issues/13037#issuecomment-2428504105
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
10 matches
Mail list logo
