alamb closed issue #10373: Auto-update mechanism for dataframe test
URL: https://github.com/apache/datafusion/issues/10373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
alamb commented on issue #10373:
URL: https://github.com/apache/datafusion/issues/10373#issuecomment-2718116201
> what do you think about
[#15165](https://github.com/apache/datafusion/pull/15165)
It is amazing😍 t- I recommend others check it out!
--
This is an automated message fr
blaginin commented on issue #10373:
URL: https://github.com/apache/datafusion/issues/10373#issuecomment-2715768413
what do you think about https://github.com/apache/datafusion/pull/15165/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
alamb commented on issue #10373:
URL: https://github.com/apache/datafusion/issues/10373#issuecomment-2714659988
I just merged
- https://github.com/apache/datafusion/pull/13672
I think it would be pretty cool to migrate a few tests to be `insta` based.
Once we had some examples I th
Omega359 commented on issue #10373:
URL: https://github.com/apache/datafusion/issues/10373#issuecomment-2706307419
I think this could be a good approach for dataframe testing. The existing
assert_batches_eq!/assert_batches_sorted_eq! macro is nice but they do how the
downside of requiring m
blaginin commented on issue #10373:
URL: https://github.com/apache/datafusion/issues/10373#issuecomment-2706281206
I agree! And moreover, we'll be able to split "harness" (set up context,
register files) from the actual test logic (stored in the small atomic
snapshots files). Happy to work
alamb commented on issue #10373:
URL: https://github.com/apache/datafusion/issues/10373#issuecomment-2704536889
I personally support introducing `insta` to datafusion testing - I think it
would make maintaining tests easier and thus lower both the maintenance burden
as well as the barrier t
wiedld commented on issue #10373:
URL: https://github.com/apache/datafusion/issues/10373#issuecomment-2704455110
Outside of sqllogictests which already has an auto-update (see the
`--complete` feature), I believe there is still an appetite for insta snapshots
which auto-update.
I se
jayzhan211 commented on issue #10373:
URL: https://github.com/apache/datafusion/issues/10373#issuecomment-2180574806
> I think this might be another approach, and we use it in databend.
https://crates.io/crates/goldenfile
>
> ```
> UPDATE_GOLDENFILES=1 cargo test
> ```
>
alamb commented on issue #10373:
URL: https://github.com/apache/datafusion/issues/10373#issuecomment-2101100092
Something we have used to great effect in influxdb is https://insta.rs/
You can then do the equivalent of `sqllogictest --complete` (even for
results within files) with a co
10 matches
Mail list logo
