Re: [I] Add Memory Profiling Functionality [datafusion]

2025-03-18 Thread via GitHub
comphead commented on issue #14510: URL: https://github.com/apache/datafusion/issues/14510#issuecomment-2734639666 The PR in arrow rs to avoid mem overcount for shared buffers https://github.com/apache/arrow-rs/pull/7303 -- This is an automated message from the Apache Git Service. To resp

Re: [I] Add Memory Profiling Functionality [datafusion]

2025-03-05 Thread via GitHub
2010YOUY01 commented on issue #14510: URL: https://github.com/apache/datafusion/issues/14510#issuecomment-2702809806 > I am interested in this function. > > [Tag memory that is allocated through the buffer manager, and add duckdb_memory() function by Mytherin · Pull Request #10496 ·

Re: [I] Add Memory Profiling Functionality [datafusion]

2025-02-27 Thread via GitHub
comphead commented on issue #14510: URL: https://github.com/apache/datafusion/issues/14510#issuecomment-2689243363 Hi @PokIsemaine I'm planning to experiment with this. One thing as you mentioned absolutely correct is to use MemoryReservation which is the helper when memory allocated thr

Re: [I] Add Memory Profiling Functionality [datafusion]

2025-02-25 Thread via GitHub
PokIsemaine commented on issue #14510: URL: https://github.com/apache/datafusion/issues/14510#issuecomment-2681616883 I am interested in this function. [Tag memory that is allocated through the buffer manager, and add duckdb_memory() function by Mytherin · Pull Request #10496 · duckd

Re: [I] Add Memory Profiling Functionality [datafusion]

2025-02-05 Thread via GitHub
berkaysynnada commented on issue #14510: URL: https://github.com/apache/datafusion/issues/14510#issuecomment-2639022364 Thank you @comphead for the great elaboration! I don't have a clear answer to your question yet, but since this is the final part of our work list, I believe someone can c

Re: [I] Add Memory Profiling Functionality [datafusion]

2025-02-05 Thread via GitHub
comphead commented on issue #14510: URL: https://github.com/apache/datafusion/issues/14510#issuecomment-2637366054 That is nice @berkaysynnada I love it. To implement it we have to use a `memory reservation` in most of intensive operations, like Sorting, Join, hash, scan, etc, now we