Re: [I] [EPIC] Improve sqlparser performance [datafusion-sqlparser-rs]

2025-05-13 Thread via GitHub
lovasoa commented on issue #1557: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1557#issuecomment-2876982494 @alamb : related: https://github.com/apache/datafusion-sqlparser-rs/pull/1848 (we are currently serializing literal strings character by character) -- This is an

Re: [I] [EPIC] Improve sqlparser performance [datafusion-sqlparser-rs]

2024-12-10 Thread via GitHub
alamb commented on issue #1557: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1557#issuecomment-2532649622 > So no idea why that --bench is apparently getting dropped but I've managed to get things going at least. 🎉 glad to hear you figured out a way past the current

Re: [I] [EPIC] Improve sqlparser performance [datafusion-sqlparser-rs]

2024-12-10 Thread via GitHub
davisp commented on issue #1557: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1557#issuecomment-2532639815 So this is kinda weird. It appears the `--bench` argument that should be passed to the benchmark isn't. Running `cargo flamegraph --root --bench sqlparser_bench

Re: [I] [EPIC] Improve sqlparser performance [datafusion-sqlparser-rs]

2024-12-09 Thread via GitHub
alamb commented on issue #1557: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1557#issuecomment-2528566898 > Locally, cargo flamegraph --bench sqlparser_bench does not appear to be doing the trick as the flamegraph appears to be at most measuring a single iteration of the b

Re: [I] [EPIC] Improve sqlparser performance [datafusion-sqlparser-rs]

2024-12-07 Thread via GitHub
davisp commented on issue #1557: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1557#issuecomment-2525239854 @alamb How are you generating your flamegraphs? Locally, `cargo flamegraph --bench sqlparser_bench` does not appear to be doing the trick as the flamegraph appe