comphead closed pull request #1205: support for `array_repeat` array function
URL: https://github.com/apache/datafusion-comet/pull/1205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
comphead commented on PR #1205:
URL:
https://github.com/apache/datafusion-comet/pull/1205#issuecomment-2836219078
Closing in favor of #1680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
jatin510 commented on PR #1205:
URL:
https://github.com/apache/datafusion-comet/pull/1205#issuecomment-2619369218
> @jatin510 builds are failing:
>
> ```
> error[E0308]: mismatched types
>--> core/src/execution/planner.rs:787:48
> |
> 787 | matc
andygrove commented on PR #1205:
URL:
https://github.com/apache/datafusion-comet/pull/1205#issuecomment-2616661130
@jatin510 builds are failing:
```
error[E0308]: mismatched types
--> core/src/execution/planner.rs:787:48
|
787 | match
count_expr
andygrove commented on PR #1205:
URL:
https://github.com/apache/datafusion-comet/pull/1205#issuecomment-2616598552
I added `array_repeat` to the follow-on issue for improving test coverage
and will merge this once CI is passing. Thanks again @jatin510.
--
This is an automated message fro
jatin510 commented on PR #1205:
URL:
https://github.com/apache/datafusion-comet/pull/1205#issuecomment-2616183089
Thanks @andygrove for the review.
we can merge this PR.
We can add more tests to other array functions in incremental way.
--
This is an automated message from the Ap
jatin510 commented on code in PR #1205:
URL: https://github.com/apache/datafusion-comet/pull/1205#discussion_r1925689396
##
native/core/src/execution/planner.rs:
##
@@ -775,6 +776,49 @@ impl PhysicalPlanner {
Ok(Arc::new(case_expr))
}
+
jatin510 commented on code in PR #1205:
URL: https://github.com/apache/datafusion-comet/pull/1205#discussion_r1925689260
##
native/core/src/execution/planner.rs:
##
@@ -775,6 +776,49 @@ impl PhysicalPlanner {
Ok(Arc::new(case_expr))
}
+
jatin510 opened a new pull request, #1205:
URL: https://github.com/apache/datafusion-comet/pull/1205
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## How are these changes
