Re: [PR] some dependency removals and setup for refactor of `FileScanConfig` [datafusion]

2025-02-08 Thread via GitHub
alamb commented on PR #14543: URL: https://github.com/apache/datafusion/pull/14543#issuecomment-2645733546 Thanks again @logan-keede -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] some dependency removals and setup for refactor of `FileScanConfig` [datafusion]

2025-02-07 Thread via GitHub
alamb merged PR #14543: URL: https://github.com/apache/datafusion/pull/14543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] some dependency removals and setup for refactor of `FileScanConfig` [datafusion]

2025-02-07 Thread via GitHub
logan-keede commented on code in PR #14543: URL: https://github.com/apache/datafusion/pull/14543#discussion_r1947229098 ## datafusion/core/src/datasource/data_source.rs: ## @@ -62,4 +62,8 @@ pub trait FileSource: Send + Sync { fn fmt_extra(&self, _t: DisplayFormatType, _f:

Re: [PR] some dependency removals and setup for refactor of `FileScanConfig` [datafusion]

2025-02-07 Thread via GitHub
alamb commented on code in PR #14543: URL: https://github.com/apache/datafusion/pull/14543#discussion_r1947226459 ## datafusion/core/src/datasource/data_source.rs: ## @@ -62,4 +62,8 @@ pub trait FileSource: Send + Sync { fn fmt_extra(&self, _t: DisplayFormatType, _f: &mut F

Re: [PR] some dependency removals and setup for refactor of `FileScanConfig` [datafusion]

2025-02-07 Thread via GitHub
logan-keede commented on code in PR #14543: URL: https://github.com/apache/datafusion/pull/14543#discussion_r1947224752 ## datafusion/core/src/datasource/data_source.rs: ## @@ -62,4 +62,8 @@ pub trait FileSource: Send + Sync { fn fmt_extra(&self, _t: DisplayFormatType, _f:

Re: [PR] some dependency removals and setup for refactor of `FileScanConfig` [datafusion]

2025-02-07 Thread via GitHub
alamb commented on code in PR #14543: URL: https://github.com/apache/datafusion/pull/14543#discussion_r1947215863 ## datafusion/core/src/datasource/data_source.rs: ## @@ -62,4 +62,8 @@ pub trait FileSource: Send + Sync { fn fmt_extra(&self, _t: DisplayFormatType, _f: &mut F

Re: [PR] some dependency removals and setup for refactor of `FileScanConfig` [datafusion]

2025-02-07 Thread via GitHub
logan-keede commented on code in PR #14543: URL: https://github.com/apache/datafusion/pull/14543#discussion_r1947182581 ## datafusion/core/src/datasource/data_source.rs: ## @@ -62,4 +62,8 @@ pub trait FileSource: Send + Sync { fn fmt_extra(&self, _t: DisplayFormatType, _f:

Re: [PR] some dependency removals and setup for refactor of `FileScanConfig` [datafusion]

2025-02-07 Thread via GitHub
logan-keede commented on code in PR #14543: URL: https://github.com/apache/datafusion/pull/14543#discussion_r1947182581 ## datafusion/core/src/datasource/data_source.rs: ## @@ -62,4 +62,8 @@ pub trait FileSource: Send + Sync { fn fmt_extra(&self, _t: DisplayFormatType, _f:

Re: [PR] some dependency removals and setup for refactor of `FileScanConfig` [datafusion]

2025-02-07 Thread via GitHub
alamb commented on code in PR #14543: URL: https://github.com/apache/datafusion/pull/14543#discussion_r1947153941 ## datafusion/core/src/datasource/data_source.rs: ## @@ -62,4 +62,8 @@ pub trait FileSource: Send + Sync { fn fmt_extra(&self, _t: DisplayFormatType, _f: &mut F

Re: [PR] some dependency removals and setup for refactor of `FileScanConfig` [datafusion]

2025-02-07 Thread via GitHub
logan-keede commented on PR #14543: URL: https://github.com/apache/datafusion/pull/14543#issuecomment-2643963541 cc @alamb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] some dependency removals and setup for refactor of `FileScanConfig` [datafusion]

2025-02-07 Thread via GitHub
logan-keede opened a new pull request, #14543: URL: https://github.com/apache/datafusion/pull/14543 ## Which issue does this PR close? - part of https://github.com/apache/datafusion/issues/14462 - Part of https://github.com/apache/datafusion/issues/1. - rework of http