Re: [PR] shell script to collect Benchmarks [datafusion]

2025-03-19 Thread via GitHub
logan-keede commented on PR #15144: URL: https://github.com/apache/datafusion/pull/15144#issuecomment-2735990428 > > Just noticed that benchmarks/README.md is not included in prettier CI check, is that intended? > > I don't think it is intended > > And I am sorry I haven't had

Re: [PR] shell script to collect Benchmarks [datafusion]

2025-03-18 Thread via GitHub
alamb commented on PR #15144: URL: https://github.com/apache/datafusion/pull/15144#issuecomment-2734597583 > Just noticed that benchmarks/README.md is not included in prettier CI check, is that intended? I don't think it is intended And I am sorry I haven't had time to test out

Re: [PR] shell script to collect Benchmarks [datafusion]

2025-03-13 Thread via GitHub
logan-keede commented on PR #15144: URL: https://github.com/apache/datafusion/pull/15144#issuecomment-2722603418 Just noticed that benchmarks/README.md is not included in prettier CI check, is that intended? -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] shell script to collect Benchmarks [datafusion]

2025-03-12 Thread via GitHub
logan-keede commented on PR #15144: URL: https://github.com/apache/datafusion/pull/15144#issuecomment-2719298050 > Sorry @logan-keede -- I am very excited to try this one out, but I ran otu of time today No problem at all! I look forward to your feedback whenever you have the time.

Re: [PR] shell script to collect Benchmarks [datafusion]

2025-03-12 Thread via GitHub
alamb commented on PR #15144: URL: https://github.com/apache/datafusion/pull/15144#issuecomment-2719240885 Sorry @logan-keede -- I am very excited to try this one out, but I ran otu of time today -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] shell script to collect Benchmarks [datafusion]

2025-03-10 Thread via GitHub
logan-keede commented on PR #15144: URL: https://github.com/apache/datafusion/pull/15144#issuecomment-2712783895 One problem that I sometimes encounter is that cargo decides to use `arrow-arith v53.4.0` for particular releases which ends up giving compilation error. I’m not sure why this

[PR] shell script to collect Benchmarks [datafusion]

2025-03-10 Thread via GitHub
logan-keede opened a new pull request, #15144: URL: https://github.com/apache/datafusion/pull/15144 ## Which issue does this PR close? - Part of #5504 ## Rationale for this change > Here is a suggestion on how to proceed with this project: > 1. Create the converte