Re: [PR] refactor: standardize div_ceil [datafusion-comet]

2025-07-09 Thread via GitHub
mbutrovich merged PR #1999: URL: https://github.com/apache/datafusion-comet/pull/1999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

Re: [PR] refactor: standardize div_ceil [datafusion-comet]

2025-07-09 Thread via GitHub
mbutrovich commented on code in PR #1999: URL: https://github.com/apache/datafusion-comet/pull/1999#discussion_r2195456222 ## native/core/src/execution/util/spark_bit_array.rs: ## @@ -103,7 +102,7 @@ impl SparkBitArray { } pub fn num_words(num_bits: i32) -> i32 { -bit::c

Re: [PR] refactor: standardize div_ceil [datafusion-comet]

2025-07-09 Thread via GitHub
mbutrovich commented on code in PR #1999: URL: https://github.com/apache/datafusion-comet/pull/1999#discussion_r2195456222 ## native/core/src/execution/util/spark_bit_array.rs: ## @@ -103,7 +102,7 @@ impl SparkBitArray { } pub fn num_words(num_bits: i32) -> i32 { -bit::c

Re: [PR] refactor: standardize div_ceil [datafusion-comet]

2025-07-08 Thread via GitHub
codecov-commenter commented on PR #1999: URL: https://github.com/apache/datafusion-comet/pull/1999#issuecomment-3049811609 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1999?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

[PR] refactor: standardize div_ceil [datafusion-comet]

2025-07-08 Thread via GitHub
tglanz opened a new pull request, #1999: URL: https://github.com/apache/datafusion-comet/pull/1999 ## Which issue does this PR close? Closes #1998. ## Rationale for this change Use standard rust implementation. Related: https://github.com/apache/datafusion-comet/pull/1