AmosAidoo commented on PR #14880:
URL: https://github.com/apache/datafusion/pull/14880#issuecomment-2683178362
😮 So proud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
alamb commented on PR #14880:
URL: https://github.com/apache/datafusion/pull/14880#issuecomment-2683172038
This PR turns out to have gotten the 10,000th commit:
alamb merged PR #14880:
URL: https://github.com/apache/datafusion/pull/14880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
AmosAidoo opened a new pull request, #14880:
URL: https://github.com/apache/datafusion/pull/14880
## Which issue does this PR close?
- Closes #11687.
## Rationale for this change
LazyLock is more ergonomic than OnceLock.
## What changes are included in
comphead merged PR #14870:
URL: https://github.com/apache/datafusion/pull/14870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
AmosAidoo commented on PR #14870:
URL: https://github.com/apache/datafusion/pull/14870#issuecomment-2682067832
Great @alamb, I'll fix those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
alamb commented on PR #14870:
URL: https://github.com/apache/datafusion/pull/14870#issuecomment-2682056505
Thanks @AmosAidoo -- looks like there are some fmt and clippy failures to
attend to
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
AmosAidoo commented on PR #14870:
URL: https://github.com/apache/datafusion/pull/14870#issuecomment-2681907431
@comphead @alamb could you kindly help trigger the CI as this is my first
contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
AmosAidoo opened a new pull request, #14870:
URL: https://github.com/apache/datafusion/pull/14870
## Which issue does this PR close?
- Closes #11687 .
## Rationale for this change
LazyLock is more ergonomic than OnceLock.
## What changes are included in
jonahgao commented on PR #13641:
URL: https://github.com/apache/datafusion/pull/13641#issuecomment-2518924963
Thanks @alamb @comphead . I plan to handle the remaining `OnceLock`s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
comphead merged PR #13641:
URL: https://github.com/apache/datafusion/pull/13641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead commented on PR #13641:
URL: https://github.com/apache/datafusion/pull/13641#issuecomment-2518016884
Thats good point, wondering we probably want to use LazyLock in
documentation generation
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
jonahgao commented on code in PR #13641:
URL: https://github.com/apache/datafusion/pull/13641#discussion_r1869044427
##
datafusion/common/src/types/builtin.rs:
##
@@ -16,17 +16,17 @@
// under the License.
use crate::types::{LogicalTypeRef, NativeType};
-use std::sync::{Arc,
jonahgao commented on code in PR #13641:
URL: https://github.com/apache/datafusion/pull/13641#discussion_r1869009027
##
datafusion/common/src/types/builtin.rs:
##
@@ -16,17 +16,17 @@
// under the License.
use crate::types::{LogicalTypeRef, NativeType};
-use std::sync::{Arc,
jonahgao commented on code in PR #13641:
URL: https://github.com/apache/datafusion/pull/13641#discussion_r1869009027
##
datafusion/common/src/types/builtin.rs:
##
@@ -16,17 +16,17 @@
// under the License.
use crate::types::{LogicalTypeRef, NativeType};
-use std::sync::{Arc,
jonahgao opened a new pull request, #13641:
URL: https://github.com/apache/datafusion/pull/13641
## Which issue does this PR close?
Clear the TODOs after updating MSRV to 1.80.
## Rationale for this change
`LazyLock` has been
[stable](https://blog.rust-lang.org/2024/07/2
16 matches
Mail list logo
