Re: [PR] perf: Experimental fix to avoid join strategy regression [datafusion-comet]

2025-04-23 Thread via GitHub
andygrove commented on PR #1674: URL: https://github.com/apache/datafusion-comet/pull/1674#issuecomment-2824086340 I will merge this so that I can start the 0.8.0 release process. Thanks for the reviews @comphead and @kazuyukitanimura, -- This is an automated message from the Apache Git

Re: [PR] perf: Experimental fix to avoid join strategy regression [datafusion-comet]

2025-04-23 Thread via GitHub
andygrove merged PR #1674: URL: https://github.com/apache/datafusion-comet/pull/1674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] perf: Experimental fix to avoid join strategy regression [datafusion-comet]

2025-04-22 Thread via GitHub
andygrove commented on code in PR #1674: URL: https://github.com/apache/datafusion-comet/pull/1674#discussion_r2055063043 ## common/src/main/scala/org/apache/comet/CometConf.scala: ## @@ -414,6 +414,16 @@ object CometConf extends ShimCometConf { .doubleConf .createWith

Re: [PR] perf: Experimental fix to avoid join strategy regression [datafusion-comet]

2025-04-22 Thread via GitHub
andygrove commented on code in PR #1674: URL: https://github.com/apache/datafusion-comet/pull/1674#discussion_r2055055647 ## common/src/main/scala/org/apache/comet/CometConf.scala: ## @@ -414,6 +414,16 @@ object CometConf extends ShimCometConf { .doubleConf .createWith

Re: [PR] perf: Experimental fix to avoid join strategy regression [datafusion-comet]

2025-04-22 Thread via GitHub
codecov-commenter commented on PR #1674: URL: https://github.com/apache/datafusion-comet/pull/1674#issuecomment-2822719099 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1674?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

Re: [PR] perf: Experimental fix to avoid join strategy regression [datafusion-comet]

2025-04-22 Thread via GitHub
kazuyukitanimura commented on code in PR #1674: URL: https://github.com/apache/datafusion-comet/pull/1674#discussion_r2054996663 ## common/src/main/scala/org/apache/comet/CometConf.scala: ## @@ -414,6 +414,16 @@ object CometConf extends ShimCometConf { .doubleConf .cre

Re: [PR] perf: Experimental fix to avoid join strategy regression [datafusion-comet]

2025-04-22 Thread via GitHub
comphead commented on code in PR #1674: URL: https://github.com/apache/datafusion-comet/pull/1674#discussion_r2054980814 ## docs/source/user-guide/configs.md: ## @@ -88,4 +88,5 @@ Comet provides the following configuration settings. | spark.comet.scan.preFetch.enabled | Whether

Re: [PR] perf: Experimental fix to avoid join strategy regression [datafusion-comet]

2025-04-22 Thread via GitHub
comphead commented on code in PR #1674: URL: https://github.com/apache/datafusion-comet/pull/1674#discussion_r2054980178 ## spark/src/main/scala/org/apache/spark/sql/comet/execution/shuffle/CometShuffleExchangeExec.scala: ## @@ -113,9 +114,9 @@ case class CometShuffleExchangeExe

[PR] perf: Experimental fix to avoid join strategy regression [datafusion-comet]

2025-04-22 Thread via GitHub
andygrove opened a new pull request, #1674: URL: https://github.com/apache/datafusion-comet/pull/1674 ## Which issue does this PR close? Closes #. ## Rationale for this change ## What changes are included in this PR? ## How are these changes