Re: [PR] optimize `initcap` function by avoiding memory allocation [datafusion]

2025-07-29 Thread via GitHub
waynexia commented on PR #16878: URL: https://github.com/apache/datafusion/pull/16878#issuecomment-3134103490 Thanks for those links! Yes they are a bit sophisticated to implement... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] optimize `initcap` function by avoiding memory allocation [datafusion]

2025-07-29 Thread via GitHub
alamb commented on PR #16878: URL: https://github.com/apache/datafusion/pull/16878#issuecomment-3133806226 > But I'm wondering if we can wrap something like ViewItemBuilder that holds the similar logic as [here](https://docs.rs/arrow-array/55.2.0/src/arrow_array/builder/generic_bytes_view_b

Re: [PR] optimize `initcap` function by avoiding memory allocation [datafusion]

2025-07-28 Thread via GitHub
waynexia commented on PR #16878: URL: https://github.com/apache/datafusion/pull/16878#issuecomment-3130089834 Thank you @alamb. >[docs.rs/arrow/latest/arrow/array/type.StringViewBuilder.html#method.append_block](https://docs.rs/arrow/latest/arrow/array/type.StringViewBuilder.html#meth

Re: [PR] optimize `initcap` function by avoiding memory allocation [datafusion]

2025-07-27 Thread via GitHub
alamb commented on PR #16878: URL: https://github.com/apache/datafusion/pull/16878#issuecomment-3124296643 Thanks again @waynexia -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] optimize `initcap` function by avoiding memory allocation [datafusion]

2025-07-27 Thread via GitHub
alamb merged PR #16878: URL: https://github.com/apache/datafusion/pull/16878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

[PR] optimize `initcap` function by avoiding memory allocation [datafusion]

2025-07-23 Thread via GitHub
waynexia opened a new pull request, #16878: URL: https://github.com/apache/datafusion/pull/16878 ## Which issue does this PR close? - A small change derived [from https://github.com/apache/datafusion/pull/13691 (discussion](https://github.com/apache/datafusion/pull/13691#disc