waynexia commented on code in PR #15327:
URL: https://github.com/apache/datafusion/pull/15327#discussion_r2006592227
##
datafusion/physical-expr/src/expressions/binary.rs:
##
@@ -793,8 +793,10 @@ impl BinaryExpr {
BitwiseShiftRight => bitwise_shift_right_dyn(left, r
waynexia merged PR #15327:
URL: https://github.com/apache/datafusion/pull/15327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
waynexia commented on PR #15327:
URL: https://github.com/apache/datafusion/pull/15327#issuecomment-2748884252
Thank you @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
waynexia commented on PR #15327:
URL: https://github.com/apache/datafusion/pull/15327#issuecomment-2741876016
>It might also be a good idea to include some documentation in the operators
themselves that DataFusion doesn't have default implementations
Added in
[5828cba](https://github
waynexia commented on PR #15327:
URL: https://github.com/apache/datafusion/pull/15327#issuecomment-2741867405
>I think there should be sql level tests (sqllogitests) that run these
operators
That's a good idea! I think I know them much better after writing some SQLs
(though none of t
alamb commented on code in PR #15327:
URL: https://github.com/apache/datafusion/pull/15327#discussion_r2005971323
##
datafusion/physical-expr/src/expressions/binary.rs:
##
@@ -793,8 +793,10 @@ impl BinaryExpr {
BitwiseShiftRight => bitwise_shift_right_dyn(left, righ
waynexia opened a new pull request, #15327:
URL: https://github.com/apache/datafusion/pull/15327
## Which issue does this PR close?
- Part of #15326
## Rationale for this change
Follows #15326, this patch includes `Arrow`, `LongArrow`, `HashArrow`,
`Has
