milenkovicm commented on PR #1275:
URL:
https://github.com/apache/datafusion-ballista/pull/1275#issuecomment-3123962588
thanks againn @Huy1Ng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
milenkovicm merged PR #1275:
URL: https://github.com/apache/datafusion-ballista/pull/1275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubsc
milenkovicm commented on PR #1275:
URL:
https://github.com/apache/datafusion-ballista/pull/1275#issuecomment-3094397765
Thanks @Huy1Ng!
As python binding has its problems I wonder if we should keep just basic
python CI active
--
This is an automated message from the Apache Git Se
Huy1Ng commented on code in PR #1275:
URL:
https://github.com/apache/datafusion-ballista/pull/1275#discussion_r2217684707
##
.github/actions/setup-builder/action.yaml:
##
@@ -37,3 +37,5 @@ runs:
rustup toolchain install ${{ inputs.rust-version }}
Review Comment:
I
Huy1Ng commented on PR #1275:
URL:
https://github.com/apache/datafusion-ballista/pull/1275#issuecomment-3094376920
this should be ready for rust. I will tackle Python workflow next. This is
going to be spitted into 3 small PRs.
--
This is an automated message from the Apache Git Service.
Huy1Ng commented on code in PR #1275:
URL:
https://github.com/apache/datafusion-ballista/pull/1275#discussion_r2217686513
##
.github/workflows/rust.yml:
##
@@ -17,275 +17,151 @@
name: Rust
+concurrency:
+ group: ${{ github.repository }}-${{ github.workflow }}
+ cancel-in
Huy1Ng commented on code in PR #1275:
URL:
https://github.com/apache/datafusion-ballista/pull/1275#discussion_r2217685871
##
.github/workflows/rust.yml:
##
@@ -17,275 +17,151 @@
name: Rust
+concurrency:
+ group: ${{ github.repository }}-${{ github.workflow }}
+ cancel-in
Huy1Ng commented on code in PR #1275:
URL:
https://github.com/apache/datafusion-ballista/pull/1275#discussion_r2217684707
##
.github/actions/setup-builder/action.yaml:
##
@@ -37,3 +37,5 @@ runs:
rustup toolchain install ${{ inputs.rust-version }}
Review Comment:
I
milenkovicm commented on code in PR #1275:
URL:
https://github.com/apache/datafusion-ballista/pull/1275#discussion_r2217581446
##
.github/actions/setup-builder/action.yaml:
##
@@ -37,3 +37,5 @@ runs:
rustup toolchain install ${{ inputs.rust-version }}
Review Comment:
milenkovicm commented on PR #1275:
URL:
https://github.com/apache/datafusion-ballista/pull/1275#issuecomment-3083345764
You don't have to if you think this is better solution. I don't know much
about this topic. What do you think ?
I guess we need to publish docker, cancel job is you
Huy1Ng commented on PR #1275:
URL:
https://github.com/apache/datafusion-ballista/pull/1275#issuecomment-3083153716
- I reused the workflows from datafusion repo. `cancel` was removed in this
commit:
https://github.com/apache/datafusion/commit/0820eb987ff9555b48a0e1704f5a8644ea4ab087#diff-2
milenkovicm commented on PR #1275:
URL:
https://github.com/apache/datafusion-ballista/pull/1275#issuecomment-3082666517
Have no access to computer at the moment. Can you please push change, it
should trigger new job
Two questions
- What's the reason to remove cancel job? It w
Huy1Ng commented on PR #1275:
URL:
https://github.com/apache/datafusion-ballista/pull/1275#issuecomment-3082356061
@milenkovicm can you rerun the CI? I pushed 2 commits too close together so
some jobs failed because they didn't get an available machine. The CI run on my
fork succeeded:
ht
Huy1Ng opened a new pull request, #1275:
URL: https://github.com/apache/datafusion-ballista/pull/1275
# Which issue does this PR close?
Part of #1128.
# Rationale for this change
In the issue
# What changes are included in this PR?
Improve the rust workflows by fol
14 matches
Mail list logo
