Re: [PR] functions: Remove NullHandling from scalar funcs [datafusion]

2025-02-07 Thread via GitHub
alamb commented on PR #14531: URL: https://github.com/apache/datafusion/pull/14531#issuecomment-2643368273 Thanks @jayzhan211 and @jkosh44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] functions: Remove NullHandling from scalar funcs [datafusion]

2025-02-07 Thread via GitHub
alamb merged PR #14531: URL: https://github.com/apache/datafusion/pull/14531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] functions: Remove NullHandling from scalar funcs [datafusion]

2025-02-06 Thread via GitHub
jkosh44 commented on PR #14531: URL: https://github.com/apache/datafusion/pull/14531#issuecomment-2641147504 I also have a PoC for how we'd make the array signatures more expressive and more easily fix the null input errors: https://github.com/apache/datafusion/pull/14532 -- This is an a

Re: [PR] functions: Remove NullHandling from scalar funcs [datafusion]

2025-02-06 Thread via GitHub
jkosh44 commented on PR #14531: URL: https://github.com/apache/datafusion/pull/14531#issuecomment-2640948421 @jayzhan211 I'm curious if you think this is a good idea or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] functions: Remove NullHandling from scalar funcs [datafusion]

2025-02-06 Thread via GitHub
jkosh44 commented on PR #14531: URL: https://github.com/apache/datafusion/pull/14531#issuecomment-2640875858 Sorry for the spam of PRs related to this issue. It turns out, IMO, that the fix to the null input issue was improving the function signature and the `NullHandling` enum did not help

[PR] functions: Remove NullHandling from scalar funcs [datafusion]

2025-02-06 Thread via GitHub
jkosh44 opened a new pull request, #14531: URL: https://github.com/apache/datafusion/pull/14531 3dfce7d33c19d6e7941b58cb7e83194c066347ca added an enum to all scalar functions called `NullHandling`, with two variants: `PassThrough` and Propagate`. `PassThrough` would pass through null inputs