Re: [PR] fix type coercion for uint/int's [datafusion]

2025-03-24 Thread via GitHub
berkaysynnada commented on code in PR #15341: URL: https://github.com/apache/datafusion/pull/15341#discussion_r2007625797 ## datafusion/expr-common/src/type_coercion/binary.rs: ## @@ -855,21 +855,14 @@ pub fn binary_numeric_coercion( (UInt64, _) | (_, UInt64) => Some(UI

Re: [PR] fix type coercion for uint/int's [datafusion]

2025-03-22 Thread via GitHub
Omega359 commented on code in PR #15341: URL: https://github.com/apache/datafusion/pull/15341#discussion_r2008808511 ## datafusion/optimizer/tests/optimizer_integration.rs: ## @@ -267,8 +267,8 @@ fn push_down_filter_groupby_expr_contains_alias() { let sql = "SELECT * FROM (

Re: [PR] fix type coercion for uint/int's [datafusion]

2025-03-22 Thread via GitHub
Omega359 commented on PR #15341: URL: https://github.com/apache/datafusion/pull/15341#issuecomment-2745343678 > However, I am struggling to understand the implications of this change to a user. Like for example, if we were going to add a note about this in the upgrade / release notes, what

Re: [PR] fix type coercion for uint/int's [datafusion]

2025-03-22 Thread via GitHub
alamb commented on code in PR #15341: URL: https://github.com/apache/datafusion/pull/15341#discussion_r2008804758 ## datafusion/optimizer/tests/optimizer_integration.rs: ## @@ -267,8 +267,8 @@ fn push_down_filter_groupby_expr_contains_alias() { let sql = "SELECT * FROM (SEL

Re: [PR] fix type coercion for uint/int's [datafusion]

2025-03-21 Thread via GitHub
Omega359 commented on code in PR #15341: URL: https://github.com/apache/datafusion/pull/15341#discussion_r2007630685 ## datafusion/expr-common/src/type_coercion/binary.rs: ## @@ -855,21 +855,14 @@ pub fn binary_numeric_coercion( (UInt64, _) | (_, UInt64) => Some(UInt64)

Re: [PR] fix type coercion for uint/int's [datafusion]

2025-03-21 Thread via GitHub
Omega359 commented on code in PR #15341: URL: https://github.com/apache/datafusion/pull/15341#discussion_r2007786253 ## datafusion/expr-common/src/type_coercion/binary.rs: ## @@ -855,21 +855,14 @@ pub fn binary_numeric_coercion( (UInt64, _) | (_, UInt64) => Some(UInt64)

Re: [PR] fix type coercion for uint/int's [datafusion]

2025-03-21 Thread via GitHub
Omega359 commented on code in PR #15341: URL: https://github.com/apache/datafusion/pull/15341#discussion_r2007786253 ## datafusion/expr-common/src/type_coercion/binary.rs: ## @@ -855,21 +855,14 @@ pub fn binary_numeric_coercion( (UInt64, _) | (_, UInt64) => Some(UInt64)

Re: [PR] fix type coercion for uint/int's [datafusion]

2025-03-21 Thread via GitHub
berkaysynnada commented on code in PR #15341: URL: https://github.com/apache/datafusion/pull/15341#discussion_r2007781920 ## datafusion/expr-common/src/type_coercion/binary.rs: ## @@ -855,21 +855,14 @@ pub fn binary_numeric_coercion( (UInt64, _) | (_, UInt64) => Some(UI

Re: [PR] fix type coercion for uint/int's [datafusion]

2025-03-21 Thread via GitHub
berkaysynnada commented on code in PR #15341: URL: https://github.com/apache/datafusion/pull/15341#discussion_r2007781920 ## datafusion/expr-common/src/type_coercion/binary.rs: ## @@ -855,21 +855,14 @@ pub fn binary_numeric_coercion( (UInt64, _) | (_, UInt64) => Some(UI

Re: [PR] fix type coercion for uint/int's [datafusion]

2025-03-21 Thread via GitHub
berkaysynnada commented on code in PR #15341: URL: https://github.com/apache/datafusion/pull/15341#discussion_r2007773712 ## datafusion/expr-common/src/type_coercion/binary.rs: ## @@ -855,21 +855,14 @@ pub fn binary_numeric_coercion( (UInt64, _) | (_, UInt64) => Some(UI

Re: [PR] fix type coercion for uint/int's [datafusion]

2025-03-21 Thread via GitHub
berkaysynnada commented on code in PR #15341: URL: https://github.com/apache/datafusion/pull/15341#discussion_r2007773712 ## datafusion/expr-common/src/type_coercion/binary.rs: ## @@ -855,21 +855,14 @@ pub fn binary_numeric_coercion( (UInt64, _) | (_, UInt64) => Some(UI

[PR] fix type coercion for uint/int's [datafusion]

2025-03-20 Thread via GitHub
Omega359 opened a new pull request, #15341: URL: https://github.com/apache/datafusion/pull/15341 ## Which issue does this PR close? - Closes #15340 ## Rationale for this change Better handle type coercion when unsigned numerics are involved ## What changes are included