alamb commented on PR #16930:
URL: https://github.com/apache/datafusion/pull/16930#issuecomment-3152393439
Gah, somehow this PR caused a CI failure:
https://github.com/apache/datafusion/actions/runs/16732639756/job/47364317932
Perhaps it undid the fix by @adamreeve here:
- ht
alamb commented on PR #16930:
URL: https://github.com/apache/datafusion/pull/16930#issuecomment-3152118010
Thanks again @acking-you and @mwylde
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
alamb merged PR #16930:
URL: https://github.com/apache/datafusion/pull/16930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
acking-you commented on code in PR #16930:
URL: https://github.com/apache/datafusion/pull/16930#discussion_r2249965371
##
datafusion/physical-expr-common/src/physical_expr.rs:
##
@@ -106,6 +106,9 @@ pub trait PhysicalExpr: Send + Sync + Display + Debug +
DynEq + DynHash {
alamb commented on code in PR #16930:
URL: https://github.com/apache/datafusion/pull/16930#discussion_r2249196239
##
datafusion/physical-expr/src/expressions/binary.rs:
##
@@ -375,7 +375,46 @@ impl PhysicalExpr for BinaryExpr {
// as it takes into account cases
acking-you commented on code in PR #16930:
URL: https://github.com/apache/datafusion/pull/16930#discussion_r2249190771
##
datafusion/physical-expr/src/expressions/binary.rs:
##
@@ -375,7 +375,19 @@ impl PhysicalExpr for BinaryExpr {
// as it takes into account c
acking-you commented on code in PR #16930:
URL: https://github.com/apache/datafusion/pull/16930#discussion_r2249183827
##
datafusion/physical-expr/src/expressions/binary.rs:
##
@@ -375,7 +375,19 @@ impl PhysicalExpr for BinaryExpr {
// as it takes into account c
alamb commented on code in PR #16930:
URL: https://github.com/apache/datafusion/pull/16930#discussion_r2240750126
##
datafusion/physical-expr/src/expressions/binary.rs:
##
@@ -375,7 +375,19 @@ impl PhysicalExpr for BinaryExpr {
// as it takes into account cases
acking-you opened a new pull request, #16930:
URL: https://github.com/apache/datafusion/pull/16930
## Which issue does this PR close?
- Closes #16928.
## Rationale for this change
## What changes are included in this PR?
## Are these changes
