Re: [PR] fix: support within_group [datafusion]

2025-06-28 Thread via GitHub
alamb commented on code in PR #16538: URL: https://github.com/apache/datafusion/pull/16538#discussion_r2173481689 ## datafusion/sql/src/expr/function.rs: ## @@ -404,6 +404,11 @@ impl SqlToRel<'_, S> { } (!within_group.is_empty()).then_so

Re: [PR] fix: support within_group [datafusion]

2025-06-25 Thread via GitHub
chenkovsky commented on code in PR #16538: URL: https://github.com/apache/datafusion/pull/16538#discussion_r2167849726 ## datafusion/sql/src/expr/function.rs: ## @@ -375,6 +375,10 @@ impl SqlToRel<'_, S> { return plan_err!("WITHIN GROUP clause is required wh

Re: [PR] fix: support within_group [datafusion]

2025-06-25 Thread via GitHub
chenkovsky commented on code in PR #16538: URL: https://github.com/apache/datafusion/pull/16538#discussion_r2167848401 ## datafusion/sqllogictest/test_files/aggregate.slt: ## @@ -7040,3 +7040,7 @@ VALUES ) GROUP BY 1 ORDER BY 1; x 1 + +statement error DataFusion error: