alamb commented on PR #16759:
URL: https://github.com/apache/datafusion/pull/16759#issuecomment-3075340476
Thanks again @feniljain and @xudong963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alamb merged PR #16759:
URL: https://github.com/apache/datafusion/pull/16759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #16759:
URL: https://github.com/apache/datafusion/pull/16759#issuecomment-3070581210
I merged up from main and pushed a commit to resolve the CI test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
feniljain commented on code in PR #16759:
URL: https://github.com/apache/datafusion/pull/16759#discussion_r2205550566
##
datafusion/functions/src/datetime/make_date.rs:
##
@@ -122,6 +122,12 @@ impl ScalarUDFImpl for MakeDateFunc {
let [years, months, days] = take_func
xudong963 commented on code in PR #16759:
URL: https://github.com/apache/datafusion/pull/16759#discussion_r2204068143
##
datafusion/functions/src/datetime/make_date.rs:
##
@@ -122,6 +122,12 @@ impl ScalarUDFImpl for MakeDateFunc {
let [years, months, days] = take_func
feniljain opened a new pull request, #16759:
URL: https://github.com/apache/datafusion/pull/16759
## Which issue does this PR close?
- Closes #16746
## Rationale for this change
Consistent make_date behavior with duck_db and postgres
## What changes are included in