Re: [PR] fix: recursive import [datafusion-python]

2025-04-28 Thread via GitHub
timsaucer merged PR #1117: URL: https://github.com/apache/datafusion-python/pull/1117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

Re: [PR] fix: recursive import [datafusion-python]

2025-04-28 Thread via GitHub
timsaucer commented on PR #1117: URL: https://github.com/apache/datafusion-python/pull/1117#issuecomment-2835242970 Actually, it's going to take a while to get all these unit tests written up so I'll merge your solution in to fix CI and then put my PR up separate. -- This is an automated

Re: [PR] fix: recursive import [datafusion-python]

2025-04-28 Thread via GitHub
timsaucer commented on PR #1117: URL: https://github.com/apache/datafusion-python/pull/1117#issuecomment-2834958727 Thank you so much. I also have a branch for this that I was going to push up, but I'll prefer your solution. I do want to add unit tests, so I might push up what I have on th

[PR] fix: recursive import [datafusion-python]

2025-04-27 Thread via GitHub
chenkovsky opened a new pull request, #1117: URL: https://github.com/apache/datafusion-python/pull/1117 # Which issue does this PR close? No # Rationale for this change expr depends on functions. functions depends on expr. there's a recursive import.