Weijun-H merged PR #15049:
URL: https://github.com/apache/datafusion/pull/15049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
Weijun-H commented on PR #15049:
URL: https://github.com/apache/datafusion/pull/15049#issuecomment-2708311998
Thanks @Blizzara and @alamb 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
Blizzara commented on PR #15049:
URL: https://github.com/apache/datafusion/pull/15049#issuecomment-2708242781
Sure, I think let’s merge this in first, then I can followup with the
removals
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
alamb commented on code in PR #15049:
URL: https://github.com/apache/datafusion/pull/15049#discussion_r1985773876
##
datafusion/functions/benches/character_length.rs:
##
@@ -26,6 +28,8 @@ fn criterion_benchmark(c: &mut Criterion) {
// All benches are single batch run with 8
Blizzara commented on PR #15049:
URL: https://github.com/apache/datafusion/pull/15049#issuecomment-2706739846
> Nice clean up! I think this pr could be merged after fix clippy issue,
thanks @Blizzara 👍
Thanks, clippy pointed out a whole bunch of invoke_batch usage, so I ended
up clea
Blizzara commented on code in PR #15049:
URL: https://github.com/apache/datafusion/pull/15049#discussion_r1985164453
##
datafusion/functions/benches/character_length.rs:
##
@@ -26,6 +28,8 @@ fn criterion_benchmark(c: &mut Criterion) {
// All benches are single batch run wit
Blizzara commented on code in PR #15049:
URL: https://github.com/apache/datafusion/pull/15049#discussion_r1984591549
##
datafusion/expr/src/udf.rs:
##
@@ -225,11 +225,13 @@ impl ScalarUDF {
self.inner.is_nullable(args, schema)
}
+#[deprecated(since = "46.0.0"
niebayes commented on code in PR #15049:
URL: https://github.com/apache/datafusion/pull/15049#discussion_r1984422261
##
datafusion/expr/src/udf.rs:
##
@@ -225,11 +225,13 @@ impl ScalarUDF {
self.inner.is_nullable(args, schema)
}
+#[deprecated(since = "46.0.0"
Blizzara opened a new pull request, #15049:
URL: https://github.com/apache/datafusion/pull/15049
## Which issue does this PR close?
See https://github.com/apache/datafusion/issues/14123#issuecomment-2703526303
## Rationale for this change
People should use `invoke_with_ar
