discord9 commented on code in PR #15854:
URL: https://github.com/apache/datafusion/pull/15854#discussion_r2074660012
##
datafusion/substrait/src/logical_plan/producer.rs:
##
@@ -1590,6 +1590,21 @@ pub fn from_cast(
schema: &DFSchemaRef,
) -> Result {
let Cast { expr,
alamb commented on PR #15854:
URL: https://github.com/apache/datafusion/pull/15854#issuecomment-2852002030
Thanks again @discord9 @vbarua and @gabotechs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
alamb merged PR #15854:
URL: https://github.com/apache/datafusion/pull/15854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #15854:
URL: https://github.com/apache/datafusion/pull/15854#issuecomment-2851983386
I restarted a failed CI run that looked to be due to some network error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vbarua commented on code in PR #15854:
URL: https://github.com/apache/datafusion/pull/15854#discussion_r2069115514
##
datafusion/substrait/src/logical_plan/producer.rs:
##
@@ -1590,6 +1590,21 @@ pub fn from_cast(
schema: &DFSchemaRef,
) -> Result {
let Cast { expr, da
discord9 commented on PR #15854:
URL: https://github.com/apache/datafusion/pull/15854#issuecomment-2842039530
Realized `try_cast` have similiar problem, will try to fix it in next PR,
the root issue is that a
`ScalarValue::Null` can't be properly translate to substrait's
`Null(DataType)
Blizzara commented on code in PR #15854:
URL: https://github.com/apache/datafusion/pull/15854#discussion_r2068664824
##
datafusion/substrait/src/logical_plan/producer.rs:
##
@@ -1590,6 +1590,21 @@ pub fn from_cast(
schema: &DFSchemaRef,
) -> Result {
let Cast { expr,
alamb commented on PR #15854:
URL: https://github.com/apache/datafusion/pull/15854#issuecomment-2841844822
I think the CI tests will pass once we merge up from main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
discord9 commented on PR #15854:
URL: https://github.com/apache/datafusion/pull/15854#issuecomment-2841594671
@vbarua might want to take a look again whether this fix is right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
discord9 commented on code in PR #15854:
URL: https://github.com/apache/datafusion/pull/15854#discussion_r2067801065
##
datafusion/substrait/src/logical_plan/producer.rs:
##
@@ -1590,6 +1590,21 @@ pub fn from_cast(
schema: &DFSchemaRef,
) -> Result {
let Cast { expr,
vbarua commented on code in PR #15854:
URL: https://github.com/apache/datafusion/pull/15854#discussion_r2067003785
##
datafusion/substrait/src/logical_plan/producer.rs:
##
@@ -1590,6 +1590,21 @@ pub fn from_cast(
schema: &DFSchemaRef,
) -> Result {
let Cast { expr, da
vbarua commented on code in PR #15854:
URL: https://github.com/apache/datafusion/pull/15854#discussion_r2067003785
##
datafusion/substrait/src/logical_plan/producer.rs:
##
@@ -1590,6 +1590,21 @@ pub fn from_cast(
schema: &DFSchemaRef,
) -> Result {
let Cast { expr, da
vbarua commented on code in PR #15854:
URL: https://github.com/apache/datafusion/pull/15854#discussion_r2067014140
##
datafusion/substrait/src/logical_plan/producer.rs:
##
@@ -1590,6 +1590,21 @@ pub fn from_cast(
schema: &DFSchemaRef,
) -> Result {
let Cast { expr, da
vbarua commented on code in PR #15854:
URL: https://github.com/apache/datafusion/pull/15854#discussion_r2067003785
##
datafusion/substrait/src/logical_plan/producer.rs:
##
@@ -1590,6 +1590,21 @@ pub fn from_cast(
schema: &DFSchemaRef,
) -> Result {
let Cast { expr, da
14 matches
Mail list logo
