alamb commented on code in PR #16606:
URL: https://github.com/apache/datafusion/pull/16606#discussion_r2173730082
##
datafusion/sql/src/expr/function.rs:
##
@@ -227,6 +227,10 @@ impl SqlToRel<'_, S> {
OVER is for window functions, whereas WITHIN GROUP is for
or
watchingthewheelsgo commented on code in PR #16606:
URL: https://github.com/apache/datafusion/pull/16606#discussion_r2173727936
##
datafusion/sql/src/expr/function.rs:
##
@@ -227,6 +227,10 @@ impl SqlToRel<'_, S> {
OVER is for window functions, whereas WITHIN GR
alamb commented on code in PR #16606:
URL: https://github.com/apache/datafusion/pull/16606#discussion_r2173688327
##
datafusion/sql/src/expr/function.rs:
##
@@ -227,6 +227,10 @@ impl SqlToRel<'_, S> {
OVER is for window functions, whereas WITHIN GROUP is for
or
alamb commented on PR #16606:
URL: https://github.com/apache/datafusion/pull/16606#issuecomment-3016152969
Thank you @watchingthewheelsgo and @findepi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
alamb merged PR #16606:
URL: https://github.com/apache/datafusion/pull/16606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
findepi commented on code in PR #16606:
URL: https://github.com/apache/datafusion/pull/16606#discussion_r2173497813
##
datafusion/sql/src/expr/function.rs:
##
@@ -227,6 +227,10 @@ impl SqlToRel<'_, S> {
OVER is for window functions, whereas WITHIN GROUP is for
alamb commented on PR #16606:
URL: https://github.com/apache/datafusion/pull/16606#issuecomment-3015971875
Thank you @watchingthewheelsgo 🙏 -- I kicked off the tests!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
watchingthewheelsgo opened a new pull request, #16606:
URL: https://github.com/apache/datafusion/pull/16606
## Which issue does this PR close?
- Closes #16596.
## Rationale for this change
## What changes are included in this PR?
raise e