Re: [PR] fix: correct the logic of transform shuffle exchange [datafusion-comet]

2025-02-10 Thread via GitHub
wForget commented on code in PR #1384: URL: https://github.com/apache/datafusion-comet/pull/1384#discussion_r1950145187 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -862,7 +862,7 @@ class CometSparkSessionExtensions newOp match

Re: [PR] fix: correct the logic of transform shuffle exchange [datafusion-comet]

2025-02-10 Thread via GitHub
wForget closed pull request #1384: fix: correct the logic of transform shuffle exchange URL: https://github.com/apache/datafusion-comet/pull/1384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] fix: correct the logic of transform shuffle exchange [datafusion-comet]

2025-02-10 Thread via GitHub
parthchandra commented on code in PR #1384: URL: https://github.com/apache/datafusion-comet/pull/1384#discussion_r1950074930 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -862,7 +862,7 @@ class CometSparkSessionExtensions newOp

[PR] fix: correct the logic of transform shuffle exchange [datafusion-comet]

2025-02-10 Thread via GitHub
wForget opened a new pull request, #1384: URL: https://github.com/apache/datafusion-comet/pull/1384 ## Which issue does this PR close? minor fix ## Rationale for this change The child of CometShuffleExchangeExec should be columnar ## What changes are included in th