Re: [PR] fix: clickbench type err [datafusion]

2025-04-28 Thread via GitHub
alamb commented on PR #15773: URL: https://github.com/apache/datafusion/pull/15773#issuecomment-2836854794 Thank you so much @chenkovsky and @xudong963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] fix: clickbench type err [datafusion]

2025-04-21 Thread via GitHub
xudong963 merged PR #15773: URL: https://github.com/apache/datafusion/pull/15773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@data

Re: [PR] fix: clickbench type err [datafusion]

2025-04-21 Thread via GitHub
xudong963 commented on PR #15773: URL: https://github.com/apache/datafusion/pull/15773#issuecomment-2817936843 Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] fix: clickbench type err [datafusion]

2025-04-21 Thread via GitHub
Weijun-H commented on code in PR #15773: URL: https://github.com/apache/datafusion/pull/15773#discussion_r2052113962 ## benchmarks/queries/clickbench/README.md: ## @@ -155,7 +155,7 @@ WHERE THEN split_part(split_part("URL", 'resolution=', 2), '&', 1)::INT ELSE

Re: [PR] fix: clickbench type err [datafusion]

2025-04-21 Thread via GitHub
Weijun-H commented on code in PR #15773: URL: https://github.com/apache/datafusion/pull/15773#discussion_r2051622969 ## benchmarks/queries/clickbench/README.md: ## @@ -155,7 +155,7 @@ WHERE THEN split_part(split_part("URL", 'resolution=', 2), '&', 1)::INT ELSE

Re: [PR] fix: clickbench type err [datafusion]

2025-04-21 Thread via GitHub
Weijun-H commented on code in PR #15773: URL: https://github.com/apache/datafusion/pull/15773#discussion_r2051622814 ## benchmarks/queries/clickbench/extended.sql: ## @@ -4,4 +4,4 @@ SELECT "BrowserCountry", COUNT(DISTINCT "SocialNetwork"), COUNT(DISTINCT "HitCo SELECT "Socia

Re: [PR] fix: clickbench type err [datafusion]

2025-04-20 Thread via GitHub
chenkovsky commented on code in PR #15773: URL: https://github.com/apache/datafusion/pull/15773#discussion_r2051868053 ## benchmarks/queries/clickbench/README.md: ## @@ -155,7 +155,7 @@ WHERE THEN split_part(split_part("URL", 'resolution=', 2), '&', 1)::INT EL

Re: [PR] fix: clickbench type err [datafusion]

2025-04-19 Thread via GitHub
Weijun-H commented on code in PR #15773: URL: https://github.com/apache/datafusion/pull/15773#discussion_r2051622969 ## benchmarks/queries/clickbench/README.md: ## @@ -155,7 +155,7 @@ WHERE THEN split_part(split_part("URL", 'resolution=', 2), '&', 1)::INT ELSE

[PR] fix: clickbench type err [datafusion]

2025-04-19 Thread via GitHub
chenkovsky opened a new pull request, #15773: URL: https://github.com/apache/datafusion/pull/15773 ## Which issue does this PR close? - Closes #15753. ## Rationale for this change column types of UTMSource and UTMCampaign in clickbench_partitioned are binary, but in