huaxingao commented on PR #2032:
URL:
https://github.com/apache/datafusion-comet/pull/2032#issuecomment-3114180980
Thank you all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
kazuyukitanimura merged PR #2032:
URL: https://github.com/apache/datafusion-comet/pull/2032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
kazuyukitanimura commented on PR #2032:
URL:
https://github.com/apache/datafusion-comet/pull/2032#issuecomment-3114074657
Merged, thanks @huaxingao @comphead @parthchandra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
huaxingao commented on code in PR #2032:
URL: https://github.com/apache/datafusion-comet/pull/2032#discussion_r2226783940
##
common/src/main/java/org/apache/comet/parquet/BatchReader.java:
##
@@ -143,7 +143,9 @@ public class BatchReader extends RecordReader implements Cl
priv
parthchandra commented on code in PR #2032:
URL: https://github.com/apache/datafusion-comet/pull/2032#discussion_r2226136383
##
common/src/main/java/org/apache/comet/parquet/BatchReader.java:
##
@@ -143,7 +143,9 @@ public class BatchReader extends RecordReader implements Cl
p
huaxingao commented on PR #2032:
URL:
https://github.com/apache/datafusion-comet/pull/2032#issuecomment-3103829451
@parthchandra I have put back the methods and marked them deprecated. Could
you please take one more look?
--
This is an automated message from the Apache Git Service.
To re
huaxingao closed pull request #2032: fix: clean up [iceberg] integration APIs
URL: https://github.com/apache/datafusion-comet/pull/2032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
huaxingao commented on code in PR #2032:
URL: https://github.com/apache/datafusion-comet/pull/2032#discussion_r2221390974
##
common/src/main/java/org/apache/comet/parquet/BatchReader.java:
##
@@ -377,12 +374,15 @@ public void init() throws URISyntaxException, IOException
{
parthchandra commented on code in PR #2032:
URL: https://github.com/apache/datafusion-comet/pull/2032#discussion_r2220720094
##
common/src/main/java/org/apache/comet/parquet/BatchReader.java:
##
@@ -377,12 +374,15 @@ public void init() throws URISyntaxException, IOException
{
parthchandra commented on PR #2032:
URL:
https://github.com/apache/datafusion-comet/pull/2032#issuecomment-3100213965
> Iceberg CI failed. We need to change the corresponding iceberg side to
make Iceberg CI pass. The required changes are in this draft
[PR](https://github.com/apache/iceberg
huaxingao commented on PR #2032:
URL:
https://github.com/apache/datafusion-comet/pull/2032#issuecomment-3100157773
Iceberg CI failed. We need to change the corresponding iceberg side to make
Iceberg CI pass. The required changes are in this draft
[PR](https://github.com/apache/iceberg/pull
huaxingao commented on code in PR #2032:
URL: https://github.com/apache/datafusion-comet/pull/2032#discussion_r2220566792
##
common/src/main/java/org/apache/comet/parquet/BatchReader.java:
##
@@ -183,9 +183,7 @@ public BatchReader(
this.taskContext = TaskContext$.MODULE$.ge
parthchandra commented on code in PR #2032:
URL: https://github.com/apache/datafusion-comet/pull/2032#discussion_r2220495577
##
common/src/main/java/org/apache/comet/parquet/BatchReader.java:
##
@@ -183,9 +183,7 @@ public BatchReader(
this.taskContext = TaskContext$.MODULE$
parthchandra commented on code in PR #2032:
URL: https://github.com/apache/datafusion-comet/pull/2032#discussion_r2217038689
##
common/src/main/java/org/apache/comet/parquet/BatchReader.java:
##
@@ -183,9 +183,7 @@ public BatchReader(
this.taskContext = TaskContext$.MODULE$
huaxingao commented on code in PR #2032:
URL: https://github.com/apache/datafusion-comet/pull/2032#discussion_r2217013989
##
common/src/main/java/org/apache/comet/parquet/BatchReader.java:
##
@@ -183,9 +183,7 @@ public BatchReader(
this.taskContext = TaskContext$.MODULE$.ge
parthchandra commented on code in PR #2032:
URL: https://github.com/apache/datafusion-comet/pull/2032#discussion_r2211880244
##
common/src/main/java/org/apache/comet/parquet/BatchReader.java:
##
@@ -183,9 +183,7 @@ public BatchReader(
this.taskContext = TaskContext$.MODULE$
codecov-commenter commented on PR #2032:
URL:
https://github.com/apache/datafusion-comet/pull/2032#issuecomment-3080720676
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/2032?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
huaxingao opened a new pull request, #2032:
URL: https://github.com/apache/datafusion-comet/pull/2032
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## How are these changes
18 matches
Mail list logo
