Re: [PR] fix: Remove COMET_SHUFFLE_FALLBACK_TO_COLUMNAR hack [datafusion-comet]

2025-06-09 Thread via GitHub
andygrove merged PR #1865: URL: https://github.com/apache/datafusion-comet/pull/1865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] fix: Remove COMET_SHUFFLE_FALLBACK_TO_COLUMNAR hack [datafusion-comet]

2025-06-09 Thread via GitHub
andygrove commented on PR #1865: URL: https://github.com/apache/datafusion-comet/pull/1865#issuecomment-2956594650 Thanks for the reviews @parthchandra and @Kontinuation. I will need to rebase this PR and update the 3.5.6 diff now that https://github.com/apache/datafusion-comet/pull/1861 i

Re: [PR] fix: Remove COMET_SHUFFLE_FALLBACK_TO_COLUMNAR hack [datafusion-comet]

2025-06-09 Thread via GitHub
parthchandra commented on PR #1865: URL: https://github.com/apache/datafusion-comet/pull/1865#issuecomment-2956180483 For the cases where we were falling back to columnar, the tests now fail (and are ignored), or are we falling back to Spark? -- This is an automated message from the Apac

Re: [PR] fix: Remove COMET_SHUFFLE_FALLBACK_TO_COLUMNAR hack [datafusion-comet]

2025-06-09 Thread via GitHub
andygrove commented on PR #1865: URL: https://github.com/apache/datafusion-comet/pull/1865#issuecomment-2956189870 > For the cases where we were falling back to columnar, the tests now fail (and are ignored), or are we falling back to Spark? Previously, we were falling back to Spark

Re: [PR] fix: Remove COMET_SHUFFLE_FALLBACK_TO_COLUMNAR hack [datafusion-comet]

2025-06-09 Thread via GitHub
andygrove commented on PR #1865: URL: https://github.com/apache/datafusion-comet/pull/1865#issuecomment-2955890140 @rluvaton @Kontinuation fyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] fix: Remove COMET_SHUFFLE_FALLBACK_TO_COLUMNAR hack [datafusion-comet]

2025-06-08 Thread via GitHub
codecov-commenter commented on PR #1865: URL: https://github.com/apache/datafusion-comet/pull/1865#issuecomment-2954133056 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1865?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

Re: [PR] fix: Remove `COMET_SHUFFLE_FALLBACK_TO_COLUMNAR` hack [datafusion-comet]

2025-06-08 Thread via GitHub
andygrove commented on PR #1736: URL: https://github.com/apache/datafusion-comet/pull/1736#issuecomment-2954113662 replaced with https://github.com/apache/datafusion-comet/pull/1865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] fix: Remove `COMET_SHUFFLE_FALLBACK_TO_COLUMNAR` hack [datafusion-comet]

2025-06-08 Thread via GitHub
andygrove closed pull request #1736: fix: Remove `COMET_SHUFFLE_FALLBACK_TO_COLUMNAR` hack URL: https://github.com/apache/datafusion-comet/pull/1736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[PR] fix: Remove COMET_SHUFFLE_FALLBACK_TO_COLUMNAR hack [datafusion-comet]

2025-06-08 Thread via GitHub
andygrove opened a new pull request, #1865: URL: https://github.com/apache/datafusion-comet/pull/1865 ## Which issue does this PR close? Part of https://github.com/apache/datafusion-comet/issues/1254 Closes https://github.com/apache/datafusion-comet/issues/1252 ##

Re: [PR] fix: Remove `COMET_SHUFFLE_FALLBACK_TO_COLUMNAR` hack [datafusion-comet]

2025-06-06 Thread via GitHub
andygrove commented on PR #1736: URL: https://github.com/apache/datafusion-comet/pull/1736#issuecomment-2950371179 Test now pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] fix: Remove `COMET_SHUFFLE_FALLBACK_TO_COLUMNAR` hack [datafusion-comet]

2025-06-06 Thread via GitHub
andygrove commented on PR #1736: URL: https://github.com/apache/datafusion-comet/pull/1736#issuecomment-2949829487 The remaining failure is related to exchange reuse in TPC-DS q44. ``` 2025-06-06T00:48:02.3079684Z OUTPUT: TakeOrderedAndProject(limit=100, orderBy=[rnk#18761 ASC NUL

Re: [PR] fix: Remove `COMET_SHUFFLE_FALLBACK_TO_COLUMNAR` hack [datafusion-comet]

2025-06-05 Thread via GitHub
andygrove commented on PR #1736: URL: https://github.com/apache/datafusion-comet/pull/1736#issuecomment-2946200491 The Spark SQL tests for 3.5.5 are now all passing, and there is just the TPC-DS issue left -- This is an automated message from the Apache Git Service. To respond to the mes