Re: [PR] fix!: incorrect coercion when comparing with string literals [datafusion]

2025-06-23 Thread via GitHub
github-actions[bot] closed pull request #15482: fix!: incorrect coercion when comparing with string literals URL: https://github.com/apache/datafusion/pull/15482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] fix!: incorrect coercion when comparing with string literals [datafusion]

2025-06-15 Thread via GitHub
github-actions[bot] commented on PR #15482: URL: https://github.com/apache/datafusion/pull/15482#issuecomment-2974908124 Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or

Re: [PR] fix!: incorrect coercion when comparing with string literals [datafusion]

2025-04-10 Thread via GitHub
alamb commented on code in PR #15482: URL: https://github.com/apache/datafusion/pull/15482#discussion_r2038079988 ## datafusion/sqllogictest/test_files/push_down_filter.slt: ## @@ -230,19 +230,19 @@ logical_plan TableScan: t projection=[a], full_filters=[t.a != Int32(100)] que

Re: [PR] fix!: incorrect coercion when comparing with string literals [datafusion]

2025-04-09 Thread via GitHub
alan910127 commented on code in PR #15482: URL: https://github.com/apache/datafusion/pull/15482#discussion_r2029954233 ## datafusion/sqllogictest/test_files/push_down_filter.slt: ## @@ -230,19 +230,19 @@ logical_plan TableScan: t projection=[a], full_filters=[t.a != Int32(100)]

Re: [PR] fix!: incorrect coercion when comparing with string literals [datafusion]

2025-04-08 Thread via GitHub
alan910127 commented on code in PR #15482: URL: https://github.com/apache/datafusion/pull/15482#discussion_r2029954233 ## datafusion/sqllogictest/test_files/push_down_filter.slt: ## @@ -230,19 +230,19 @@ logical_plan TableScan: t projection=[a], full_filters=[t.a != Int32(100)]

Re: [PR] fix!: incorrect coercion when comparing with string literals [datafusion]

2025-04-05 Thread via GitHub
alan910127 commented on code in PR #15482: URL: https://github.com/apache/datafusion/pull/15482#discussion_r2029961032 ## datafusion/optimizer/src/analyzer/type_coercion.rs: ## @@ -290,12 +290,31 @@ impl<'a> TypeCoercionRewriter<'a> { right: Expr, right_schema:

Re: [PR] fix!: incorrect coercion when comparing with string literals [datafusion]

2025-04-05 Thread via GitHub
alan910127 commented on code in PR #15482: URL: https://github.com/apache/datafusion/pull/15482#discussion_r2029954233 ## datafusion/sqllogictest/test_files/push_down_filter.slt: ## @@ -230,19 +230,19 @@ logical_plan TableScan: t projection=[a], full_filters=[t.a != Int32(100)]

Re: [PR] fix!: incorrect coercion when comparing with string literals [datafusion]

2025-04-05 Thread via GitHub
alan910127 commented on code in PR #15482: URL: https://github.com/apache/datafusion/pull/15482#discussion_r2029954233 ## datafusion/sqllogictest/test_files/push_down_filter.slt: ## @@ -230,19 +230,19 @@ logical_plan TableScan: t projection=[a], full_filters=[t.a != Int32(100)]

Re: [PR] fix!: incorrect coercion when comparing with string literals [datafusion]

2025-04-05 Thread via GitHub
gabotechs commented on code in PR #15482: URL: https://github.com/apache/datafusion/pull/15482#discussion_r2024939228 ## datafusion/sqllogictest/test_files/push_down_filter.slt: ## @@ -230,19 +230,19 @@ logical_plan TableScan: t projection=[a], full_filters=[t.a != Int32(100)]

Re: [PR] fix!: incorrect coercion when comparing with string literals [datafusion]

2025-04-04 Thread via GitHub
alan910127 commented on code in PR #15482: URL: https://github.com/apache/datafusion/pull/15482#discussion_r2025222514 ## datafusion/sqllogictest/test_files/push_down_filter.slt: ## @@ -230,19 +230,19 @@ logical_plan TableScan: t projection=[a], full_filters=[t.a != Int32(100)]

Re: [PR] fix!: incorrect coercion when comparing with string literals [datafusion]

2025-04-03 Thread via GitHub
alamb commented on code in PR #15482: URL: https://github.com/apache/datafusion/pull/15482#discussion_r202663 ## datafusion/optimizer/src/analyzer/type_coercion.rs: ## @@ -290,12 +290,31 @@ impl<'a> TypeCoercionRewriter<'a> { right: Expr, right_schema: &DFS

Re: [PR] fix!: incorrect coercion when comparing with string literals [datafusion]

2025-03-29 Thread via GitHub
alan910127 commented on code in PR #15482: URL: https://github.com/apache/datafusion/pull/15482#discussion_r2019692309 ## datafusion/sqllogictest/test_files/push_down_filter.slt: ## @@ -230,19 +230,19 @@ logical_plan TableScan: t projection=[a], full_filters=[t.a != Int32(100)]

Re: [PR] fix!: incorrect coercion when comparing with string literals [datafusion]

2025-03-28 Thread via GitHub
alan910127 commented on code in PR #15482: URL: https://github.com/apache/datafusion/pull/15482#discussion_r2019692309 ## datafusion/sqllogictest/test_files/push_down_filter.slt: ## @@ -230,19 +230,19 @@ logical_plan TableScan: t projection=[a], full_filters=[t.a != Int32(100)]

Re: [PR] fix!: incorrect coercion when comparing with string literals [datafusion]

2025-03-28 Thread via GitHub
jayzhan211 commented on code in PR #15482: URL: https://github.com/apache/datafusion/pull/15482#discussion_r2019668440 ## datafusion/sqllogictest/test_files/push_down_filter.slt: ## @@ -230,19 +230,19 @@ logical_plan TableScan: t projection=[a], full_filters=[t.a != Int32(100)]

[PR] fix!: incorrect coercion when comparing with string literals [datafusion]

2025-03-28 Thread via GitHub
alan910127 opened a new pull request, #15482: URL: https://github.com/apache/datafusion/pull/15482 ## Which issue does this PR close? - Closes #15161. ## Rationale for this change Currently, DataFusion handles comparisons between numbers and string litera

Re: [PR] fix!: incorrect coercion when comparing with string literals [datafusion]

2025-03-28 Thread via GitHub
alan910127 commented on code in PR #15482: URL: https://github.com/apache/datafusion/pull/15482#discussion_r2019310584 ## datafusion/core/tests/expr_api/mod.rs: ## @@ -330,12 +330,12 @@ async fn test_create_physical_expr_coercion() { create_expr_test(lit(1i32).eq(col("id"))