zhuqi-lucas commented on PR #16196:
URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2915817369
I polish the code only affect the no grouping aggregate, maybe we can
compare the clickbench, so we can be confident to merge if it not affect
aggregate performance.
--
This i
zhuqi-lucas commented on PR #16196:
URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2914829035
Thank you @alamb for review and benchmark.
I am wandering if it will hit datafusion itself running performance, because
we add (if logic) in the aggregate and other core ex
alamb commented on PR #16196:
URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2913787277
🤖: Benchmark completed
Details
```
Comparing HEAD and issue_16193
Benchmark cancellation.json
┏
alamb commented on PR #16196:
URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2913785796
🤖 `./gh_compare_branch.sh` [Benchmark
Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch.sh)
Running
Linux aal-dev 6.11.0-1013-gcp #13~24.04.1-Ubun
alamb commented on PR #16196:
URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2913500070
🤖 `./gh_compare_branch.sh` [Benchmark
Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch.sh)
Running
Linux aal-dev 6.11.0-1013-gcp #13~24.04.1-Ubun
alamb commented on PR #16196:
URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2913496366
Thanks @zhuqi-lucas -- I'll try running the cancellation benchmark from
@carols10cents
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
