Re: [PR] feat: simplify regex wildcard pattern [datafusion]

2025-04-05 Thread via GitHub
waynexia commented on code in PR #15299: URL: https://github.com/apache/datafusion/pull/15299#discussion_r2004397798 ## datafusion/optimizer/src/simplify_expressions/regex.rs: ## @@ -43,6 +47,23 @@ pub fn simplify_regex_expr( let mode = OperatorMode::new(&op); if let

Re: [PR] feat: simplify regex wildcard pattern [datafusion]

2025-04-05 Thread via GitHub
alamb commented on code in PR #15299: URL: https://github.com/apache/datafusion/pull/15299#discussion_r2004125741 ## datafusion/optimizer/src/simplify_expressions/regex.rs: ## @@ -43,6 +47,23 @@ pub fn simplify_regex_expr( let mode = OperatorMode::new(&op); if let Ex

Re: [PR] feat: simplify regex wildcard pattern [datafusion]

2025-03-21 Thread via GitHub
waynexia merged PR #15299: URL: https://github.com/apache/datafusion/pull/15299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@dataf

Re: [PR] feat: simplify regex wildcard pattern [datafusion]

2025-03-21 Thread via GitHub
waynexia commented on PR #15299: URL: https://github.com/apache/datafusion/pull/15299#issuecomment-2744557761 Thank you for reviewing @jayzhan211 @alamb :heart: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] feat: simplify regex wildcard pattern [datafusion]

2025-03-20 Thread via GitHub
waynexia commented on code in PR #15299: URL: https://github.com/apache/datafusion/pull/15299#discussion_r2006630060 ## datafusion/sqllogictest/test_files/union.slt: ## @@ -910,8 +910,8 @@ SELECT * FROM (SELECT y FROM u1 UNION ALL SELECT y FROM u2) ORDER BY y; query I SELECT

Re: [PR] feat: simplify regex wildcard pattern [datafusion]

2025-03-19 Thread via GitHub
jayzhan211 commented on code in PR #15299: URL: https://github.com/apache/datafusion/pull/15299#discussion_r2004540986 ## datafusion/sqllogictest/test_files/union.slt: ## @@ -910,8 +910,8 @@ SELECT * FROM (SELECT y FROM u1 UNION ALL SELECT y FROM u2) ORDER BY y; query I SELEC

Re: [PR] feat: simplify regex wildcard pattern [datafusion]

2025-03-18 Thread via GitHub
jayzhan211 commented on code in PR #15299: URL: https://github.com/apache/datafusion/pull/15299#discussion_r2002218628 ## datafusion/optimizer/src/simplify_expressions/regex.rs: ## @@ -43,6 +45,23 @@ pub fn simplify_regex_expr( let mode = OperatorMode::new(&op); if l

[PR] feat: simplify regex wildcard pattern [datafusion]

2025-03-18 Thread via GitHub
waynexia opened a new pull request, #15299: URL: https://github.com/apache/datafusion/pull/15299 ## Which issue does this PR close? - Closes #. ## Rationale for this change Simplify dump regex cases like `~ '.*'` or `!~ '.*'`. ## What changes are in