Re: [PR] feat: remove DataFusion pyarrow feat [datafusion-python]

2025-02-01 Thread via GitHub
timsaucer merged PR #1000: URL: https://github.com/apache/datafusion-python/pull/1000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

Re: [PR] feat: remove DataFusion pyarrow feat [datafusion-python]

2025-02-01 Thread via GitHub
timsaucer commented on code in PR #1000: URL: https://github.com/apache/datafusion-python/pull/1000#discussion_r1938270795 ## src/config.rs: ## @@ -40,7 +42,7 @@ impl PyConfig { #[staticmethod] pub fn from_env() -> PyResult { Review Comment: Excellent suggestion!

Re: [PR] feat: remove DataFusion pyarrow feat [datafusion-python]

2025-01-28 Thread via GitHub
kylebarron commented on code in PR #1000: URL: https://github.com/apache/datafusion-python/pull/1000#discussion_r1932699499 ## src/config.rs: ## @@ -40,7 +42,7 @@ impl PyConfig { #[staticmethod] pub fn from_env() -> PyResult { Review Comment: Instead of always cal

Re: [PR] feat: remove DataFusion pyarrow feat [datafusion-python]

2025-01-28 Thread via GitHub
matko commented on code in PR #1000: URL: https://github.com/apache/datafusion-python/pull/1000#discussion_r1932009641 ## src/pyarrow_util.rs: ## Review Comment: it would be good to have the conversion functions in this file also available directly on a `ScalarValue`, whi

Re: [PR] feat: remove DataFusion pyarrow feat [datafusion-python]

2025-01-21 Thread via GitHub
kylebarron commented on PR #1000: URL: https://github.com/apache/datafusion-python/pull/1000#issuecomment-2605913460 > By removing the `pyarrow` dependency of DataFusion we can update `pyo3` in without requiring corresponding updates to the DataFusion core repository. FWIW this is a

[PR] feat: remove DataFusion pyarrow feat [datafusion-python]

2025-01-20 Thread via GitHub
timsaucer opened a new pull request, #1000: URL: https://github.com/apache/datafusion-python/pull/1000 # Which issue does this PR close? This addresses part of https://github.com/apache/datafusion/issues/14197 # Rationale for this change By removing the `pyarrow` depende