Re: [PR] feat: regexp_replace() expression with no starting offset [datafusion-comet]

2025-05-05 Thread via GitHub
andygrove merged PR #1700: URL: https://github.com/apache/datafusion-comet/pull/1700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] feat: regexp_replace() expression with no starting offset [datafusion-comet]

2025-05-02 Thread via GitHub
mbutrovich commented on code in PR #1700: URL: https://github.com/apache/datafusion-comet/pull/1700#discussion_r2071746681 ## spark/src/test/scala/org/apache/comet/CometFuzzTestSuite.scala: ## @@ -188,6 +188,22 @@ class CometFuzzTestSuite extends CometTestBase with AdaptiveSpar

Re: [PR] feat: regexp_replace() expression with no starting offset [datafusion-comet]

2025-05-01 Thread via GitHub
mbutrovich commented on code in PR #1700: URL: https://github.com/apache/datafusion-comet/pull/1700#discussion_r2070460938 ## spark/src/test/scala/org/apache/comet/CometFuzzTestSuite.scala: ## @@ -188,6 +188,22 @@ class CometFuzzTestSuite extends CometTestBase with AdaptiveSpar

Re: [PR] feat: regexp_replace() expression with no starting offset [datafusion-comet]

2025-05-01 Thread via GitHub
andygrove commented on code in PR #1700: URL: https://github.com/apache/datafusion-comet/pull/1700#discussion_r2070420243 ## spark/src/test/scala/org/apache/comet/CometFuzzTestSuite.scala: ## @@ -188,6 +188,22 @@ class CometFuzzTestSuite extends CometTestBase with AdaptiveSpark

Re: [PR] feat: regexp_replace() expression with no starting offset [datafusion-comet]

2025-05-01 Thread via GitHub
andygrove commented on code in PR #1700: URL: https://github.com/apache/datafusion-comet/pull/1700#discussion_r2070408978 ## spark/src/test/scala/org/apache/comet/CometFuzzTestSuite.scala: ## @@ -188,6 +188,22 @@ class CometFuzzTestSuite extends CometTestBase with AdaptiveSpark

Re: [PR] feat: regexp_replace() expression with no starting offset [datafusion-comet]

2025-04-30 Thread via GitHub
codecov-commenter commented on PR #1700: URL: https://github.com/apache/datafusion-comet/pull/1700#issuecomment-2842878963 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1700?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

Re: [PR] feat: regexp_replace() expression with no starting offset [datafusion-comet]

2025-04-30 Thread via GitHub
mbutrovich commented on PR #1700: URL: https://github.com/apache/datafusion-comet/pull/1700#issuecomment-2842651369 I should probably add some better tests, since now that we're checking the flag that means we won't get coverage in the Spark SQL tests -- we'll just fall back. -- This is

Re: [PR] feat: regexp_replace() expression with no starting offset [datafusion-comet]

2025-04-30 Thread via GitHub
andygrove commented on code in PR #1700: URL: https://github.com/apache/datafusion-comet/pull/1700#discussion_r2068997181 ## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ## @@ -1430,6 +1430,27 @@ object QueryPlanSerde extends Logging with CometExprShim {

Re: [PR] feat: regexp_replace() expression with no starting offset [datafusion-comet]

2025-04-30 Thread via GitHub
andygrove commented on code in PR #1700: URL: https://github.com/apache/datafusion-comet/pull/1700#discussion_r2068997865 ## spark/src/test/scala/org/apache/comet/CometFuzzTestSuite.scala: ## @@ -188,6 +188,20 @@ class CometFuzzTestSuite extends CometTestBase with AdaptiveSpark

Re: [PR] feat: regexp_replace() expression with no starting offset [datafusion-comet]

2025-04-30 Thread via GitHub
andygrove commented on code in PR #1700: URL: https://github.com/apache/datafusion-comet/pull/1700#discussion_r2068995618 ## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ## @@ -1430,6 +1430,27 @@ object QueryPlanSerde extends Logging with CometExprShim {