Re: [PR] feat: pass ignore_nulls flag to first and last [datafusion-comet]

2025-06-23 Thread via GitHub
andygrove merged PR #1866: URL: https://github.com/apache/datafusion-comet/pull/1866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] feat: pass ignore_nulls flag to first and last [datafusion-comet]

2025-06-19 Thread via GitHub
rluvaton commented on PR #1866: URL: https://github.com/apache/datafusion-comet/pull/1866#issuecomment-2988542503 sorry, missed your comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] feat: pass ignore_nulls flag to first and last [datafusion-comet]

2025-06-16 Thread via GitHub
andygrove commented on PR #1866: URL: https://github.com/apache/datafusion-comet/pull/1866#issuecomment-2976849328 @rluvaton Here is a test that fails in main and passes with your changes in this PR. Could you add this to `CometAggregateSuite` as part of this PR? ```scala test("

Re: [PR] feat: pass ignore_nulls flag to first and last [datafusion-comet]

2025-06-16 Thread via GitHub
andygrove commented on PR #1866: URL: https://github.com/apache/datafusion-comet/pull/1866#issuecomment-2976754152 I will create a PR today to add correctness tests for first/last. We can then rebase this PR and make sure that there are no regressions. -- This is an automated message fro

Re: [PR] feat: pass ignore_nulls flag to first and last [datafusion-comet]

2025-06-13 Thread via GitHub
parthchandra commented on PR #1866: URL: https://github.com/apache/datafusion-comet/pull/1866#issuecomment-2971722751 @andygrove perhaps we can merge this while we wait for the tests to be made more accurate? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] feat: pass ignore_nulls flag to first and last [datafusion-comet]

2025-06-13 Thread via GitHub
andygrove commented on PR #1866: URL: https://github.com/apache/datafusion-comet/pull/1866#issuecomment-2970625122 > All the tests for first and last are disabled currently: > > * [Re-enable tests for FIRST/LAST #1646](https://github.com/apache/datafusion-comet/issues/1646)

Re: [PR] feat: pass ignore_nulls flag to first and last [datafusion-comet]

2025-06-11 Thread via GitHub
rluvaton commented on PR #1866: URL: https://github.com/apache/datafusion-comet/pull/1866#issuecomment-2961843908 All the tests are disabled currently -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] feat: pass ignore_nulls flag to first and last [datafusion-comet]

2025-06-09 Thread via GitHub
codecov-commenter commented on PR #1866: URL: https://github.com/apache/datafusion-comet/pull/1866#issuecomment-2956336470 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1866?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

Re: [PR] feat: pass ignore_nulls flag to first and last [datafusion-comet]

2025-06-09 Thread via GitHub
parthchandra commented on PR #1866: URL: https://github.com/apache/datafusion-comet/pull/1866#issuecomment-2956276128 The linked PR did not add a test. Would you be able to? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] feat: pass ignore_nulls flag to first and last [datafusion-comet]

2025-06-08 Thread via GitHub
rluvaton opened a new pull request, #1866: URL: https://github.com/apache/datafusion-comet/pull/1866 ## Which issue does this PR close? N/A ## Rationale for this change Actually use `ignore_nulls` that was used in: - #1626 ## What changes are included in this