zhuqi-lucas commented on code in PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#discussion_r2152536175
##
datafusion/common/src/config.rs:
##
@@ -259,10 +259,10 @@ config_namespace! {
/// string length and thus DataFusion can not enforce such limits.
xudong963 commented on code in PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#discussion_r2151302101
##
datafusion/common/src/config.rs:
##
@@ -259,10 +259,10 @@ config_namespace! {
/// string length and thus DataFusion can not enforce such limits.
xudong963 merged PR #16290:
URL: https://github.com/apache/datafusion/pull/16290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
zhuqi-lucas commented on code in PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#discussion_r2151238976
##
datafusion/sqllogictest/test_files/array.slt:
##
@@ -6082,7 +6082,7 @@ physical_plan
04)--AggregateExec: mode=Partial, gby=[], aggr=[count(Int64(1))]
zhuqi-lucas commented on code in PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#discussion_r2151211169
##
datafusion/common/src/config.rs:
##
@@ -259,10 +259,10 @@ config_namespace! {
/// string length and thus DataFusion can not enforce such limits.
alamb commented on code in PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#discussion_r2150955809
##
datafusion/common/src/config.rs:
##
@@ -259,10 +259,10 @@ config_namespace! {
/// string length and thus DataFusion can not enforce such limits.
zhuqi-lucas commented on PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#issuecomment-2976695923
> Some tests are failing
Fixed in latest PR, thank you @xudong963 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
xudong963 commented on PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#issuecomment-2976464829
Some tests are failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
zhuqi-lucas commented on code in PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#discussion_r2140014498
##
datafusion/common/src/config.rs:
##
@@ -264,6 +264,11 @@ config_namespace! {
/// Default is false.
pub map_varchar_to_utf8view: bool, defau
xudong963 commented on code in PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#discussion_r2139721916
##
datafusion/common/src/config.rs:
##
@@ -264,6 +264,11 @@ config_namespace! {
/// Default is false.
pub map_varchar_to_utf8view: bool, default
zhuqi-lucas commented on code in PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#discussion_r2139760202
##
datafusion/common/src/config.rs:
##
@@ -264,6 +264,11 @@ config_namespace! {
/// Default is false.
pub map_varchar_to_utf8view: bool, defau
zhuqi-lucas commented on code in PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#discussion_r2139687609
##
datafusion/common/src/config.rs:
##
@@ -264,6 +264,11 @@ config_namespace! {
/// Default is false.
pub map_varchar_to_utf8view: bool, defau
xudong963 commented on code in PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#discussion_r2139606271
##
datafusion/common/src/config.rs:
##
@@ -264,6 +264,11 @@ config_namespace! {
/// Default is false.
pub map_varchar_to_utf8view: bool, default
zhuqi-lucas commented on PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#issuecomment-2961517733
Hi @alamb @xudong963 , i have fixed all the corner cases in this PR, it's
ready for review! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to t
zhuqi-lucas commented on code in PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#discussion_r2139142869
##
datafusion/sqllogictest/test_files/arrow_files.slt:
##
@@ -61,22 +61,12 @@ LOCATION '../core/tests/data/partitioned_table_arrow/'
PARTITIONED BY (part);
zhuqi-lucas commented on code in PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#discussion_r2139142869
##
datafusion/sqllogictest/test_files/arrow_files.slt:
##
@@ -61,22 +61,12 @@ LOCATION '../core/tests/data/partitioned_table_arrow/'
PARTITIONED BY (part);
zhuqi-lucas commented on code in PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#discussion_r2139142869
##
datafusion/sqllogictest/test_files/arrow_files.slt:
##
@@ -61,22 +61,12 @@ LOCATION '../core/tests/data/partitioned_table_arrow/'
PARTITIONED BY (part);
alamb commented on code in PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#discussion_r2134860028
##
datafusion/sqllogictest/test_files/arrow_files.slt:
##
@@ -61,22 +61,12 @@ LOCATION '../core/tests/data/partitioned_table_arrow/'
PARTITIONED BY (part);
# sel
zhuqi-lucas commented on code in PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#discussion_r2134715891
##
datafusion/sqllogictest/test_files/arrow_files.slt:
##
@@ -61,22 +61,12 @@ LOCATION '../core/tests/data/partitioned_table_arrow/'
PARTITIONED BY (part);
zhuqi-lucas commented on code in PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#discussion_r2134525536
##
datafusion/expr-common/src/type_coercion/binary.rs:
##
@@ -1202,7 +1202,7 @@ pub fn string_coercion(lhs_type: &DataType, rhs_type:
&DataType) -> Option
Op
zhuqi-lucas opened a new pull request, #16290:
URL: https://github.com/apache/datafusion/pull/16290
## Which issue does this PR close?
- Closes[ #16288](https://github.com/apache/datafusion/issues/16288)
## Rationale for this change
Similar to
http
21 matches
Mail list logo
