Re: [PR] feat: make parquet native scan schema case insensitive [datafusion-comet]

2025-03-28 Thread via GitHub
parthchandra commented on code in PR #1575: URL: https://github.com/apache/datafusion-comet/pull/1575#discussion_r2019608751 ## spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala: ## @@ -1460,6 +1460,25 @@ class ParquetReadV1Suite extends ParquetReadSuite with

Re: [PR] feat: make parquet native scan schema case insensitive [datafusion-comet]

2025-03-28 Thread via GitHub
kazuyukitanimura commented on PR #1575: URL: https://github.com/apache/datafusion-comet/pull/1575#issuecomment-2762019121 Merged, thanks @wForget -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] feat: make parquet native scan schema case insensitive [datafusion-comet]

2025-03-28 Thread via GitHub
kazuyukitanimura merged PR #1575: URL: https://github.com/apache/datafusion-comet/pull/1575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

Re: [PR] feat: make parquet native scan schema case insensitive [datafusion-comet]

2025-03-27 Thread via GitHub
wForget commented on code in PR #1575: URL: https://github.com/apache/datafusion-comet/pull/1575#discussion_r2017798341 ## native/core/src/parquet/parquet_exec.rs: ## @@ -110,6 +110,7 @@ fn get_options(session_timezone: &str) -> (TableParquetOptions, SparkParquetOpti let m

Re: [PR] feat: make parquet native scan schema case insensitive [datafusion-comet]

2025-03-27 Thread via GitHub
kazuyukitanimura commented on code in PR #1575: URL: https://github.com/apache/datafusion-comet/pull/1575#discussion_r2017507949 ## native/core/src/parquet/parquet_exec.rs: ## @@ -110,6 +110,7 @@ fn get_options(session_timezone: &str) -> (TableParquetOptions, SparkParquetOpti

Re: [PR] feat: make parquet native scan schema case insensitive [datafusion-comet]

2025-03-27 Thread via GitHub
codecov-commenter commented on PR #1575: URL: https://github.com/apache/datafusion-comet/pull/1575#issuecomment-2758515840 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1575?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

[PR] feat: make parquet native scan schema case insensitive [datafusion-comet]

2025-03-27 Thread via GitHub
wForget opened a new pull request, #1575: URL: https://github.com/apache/datafusion-comet/pull/1575 ## Which issue does this PR close? Part of #1574. ## Rationale for this change The data schema of spark parquet datasource scan may not be consistent with the actual schem

Re: [PR] feat: make parquet native scan schema case insensitive [datafusion-comet]

2025-03-27 Thread via GitHub
wForget commented on code in PR #1575: URL: https://github.com/apache/datafusion-comet/pull/1575#discussion_r2016533206 ## spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala: ## @@ -1460,6 +1460,25 @@ class ParquetReadV1Suite extends ParquetReadSuite with Adap