parthchandra commented on PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#issuecomment-2735075699
> @parthchandra Consulting a question: In the current compilation script
`dev/release/build-release-comet.sh`, the final invocation of the compilation
command is `core-amd64-l
dpengpeng commented on PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#issuecomment-2731538887
@parthchandra Consulting a question: In the current compilation script
`dev/release/build-release-comet.sh`, the final invocation of the compilation
command is `core-amd64-libs`
andygrove merged PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@da
parthchandra commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1767359468
##
Makefile:
##
@@ -46,6 +46,22 @@ format:
./mvnw compile test-compile scalafix:scalafix -Psemanticdb $(PROFILES)
./mvnw spotless:apply $(PR
viirya commented on PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#issuecomment-2361561256
Looks good to me, with a few minor questions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
viirya commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1767185241
##
dev/release/build-release-comet.sh:
##
@@ -0,0 +1,202 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor l
viirya commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1767167884
##
Makefile:
##
@@ -46,6 +46,22 @@ format:
./mvnw compile test-compile scalafix:scalafix -Psemanticdb $(PROFILES)
./mvnw spotless:apply $(PROFILES
viirya commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1767163890
##
Makefile:
##
@@ -46,6 +46,22 @@ format:
./mvnw compile test-compile scalafix:scalafix -Psemanticdb $(PROFILES)
./mvnw spotless:apply $(PROFILES
parthchandra commented on PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#issuecomment-2361465911
@viirya Any further comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
parthchandra commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1764078076
##
dev/release/comet-rm/Dockerfile:
##
@@ -0,0 +1,91 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agre
parthchandra commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1764074981
##
dev/release/comet-rm/Dockerfile:
##
@@ -0,0 +1,91 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agre
parthchandra commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1764003176
##
Makefile:
##
@@ -46,6 +46,30 @@ format:
./mvnw compile test-compile scalafix:scalafix -Psemanticdb $(PROFILES)
./mvnw spotless:apply $(PR
viirya commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1763986270
##
dev/release/comet-rm/Dockerfile:
##
@@ -0,0 +1,91 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements
viirya commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1763982363
##
Makefile:
##
@@ -46,6 +46,30 @@ format:
./mvnw compile test-compile scalafix:scalafix -Psemanticdb $(PROFILES)
./mvnw spotless:apply $(PROFILES
viirya commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1763844471
##
Makefile:
##
@@ -46,6 +46,30 @@ format:
./mvnw compile test-compile scalafix:scalafix -Psemanticdb $(PROFILES)
./mvnw spotless:apply $(PROFILES
viirya commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1763825880
##
Makefile:
##
@@ -46,6 +46,30 @@ format:
./mvnw compile test-compile scalafix:scalafix -Psemanticdb $(PROFILES)
./mvnw spotless:apply $(PROFILES
parthchandra commented on PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#issuecomment-2353989924
@andygrove thank you for testing! This is ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
parthchandra commented on PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#issuecomment-2353988310
The artifact
```
149504624 Wed Jan 22 15:10:16 MST 2020
org/apache/comet/darwin/aarch64/libcomet.dylib
```
seems to be a leftover from a manual run. The script wil
andygrove commented on PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#issuecomment-2353772043
I ran the scripts locally and they seem to have worked.
I ran this command:
```
./dev/release/build-release-comet.sh -r
https://github.com/parthchandra/datafusio
parthchandra commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1761600209
##
dev/release/build-release-comet.sh:
##
@@ -0,0 +1,168 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contrib
andygrove commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1761570516
##
dev/release/comet-rm/build-comet-native-libs.sh:
##
@@ -0,0 +1,52 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or mor
andygrove commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1761569452
##
dev/release/comet-rm/build-comet-native-libs.sh:
##
@@ -0,0 +1,52 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or mor
andygrove commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1761569452
##
dev/release/comet-rm/build-comet-native-libs.sh:
##
@@ -0,0 +1,52 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or mor
viirya commented on PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#issuecomment-2349614678
Hmm, I think for OSS Comet we don't have the restriction on supported glibc
for platform compatibility. Glibc 2.31 seems to be released on 2020. I think it
is old enough for the com
parthchandra commented on PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#issuecomment-2349521769
@andygrove @viirya For the binary builder I chose to use Ubuntu 20.04 as the
base image because that is the image we currently use for our published docker
images.
Ubuntu
parthchandra commented on PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#issuecomment-2349402578
@andygrove I changed the script to build a different image for each
architecture instead of a single multi-arch image. It makes things much simpler
at the cost of having multi
parthchandra commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1757337257
##
dev/release/build-release-comet.sh:
##
@@ -0,0 +1,168 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contrib
andygrove commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1755638170
##
dev/release/build-release-comet.sh:
##
@@ -0,0 +1,168 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributo
andygrove commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1755632986
##
dev/release/build-release-comet.sh:
##
@@ -0,0 +1,168 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributo
andygrove commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1755618430
##
dev/release/build-release-comet.sh:
##
@@ -0,0 +1,168 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributo
andygrove commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1755613202
##
dev/release/build-release-comet.sh:
##
@@ -0,0 +1,168 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributo
andygrove commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1755606820
##
dev/release/build-release-comet.sh:
##
@@ -0,0 +1,168 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributo
parthchandra commented on PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#issuecomment-2342243867
MacOS build hits this - https://github.com/BLAKE3-team/BLAKE3/issues/180.
Will try the suggested solutions.
--
This is an automated message from the Apache Git Service.
To r
parthchandra opened a new pull request, #932:
URL: https://github.com/apache/datafusion-comet/pull/932
## Which issue does this PR close?
Closes #721
## Rationale for this change
Allows us to publish artifacts to maven
## What changes are included in this PR?
34 matches
Mail list logo
