alamb commented on PR #15772:
URL: https://github.com/apache/datafusion/pull/15772#issuecomment-2854191669
> This looks ready now, thanks @PokIsemaine. I'll merge it after a few hours
unless someone else brings any suggestion here
Thanks @PokIsemaine and @berkaysynnada - I also added
berkaysynnada merged PR #15772:
URL: https://github.com/apache/datafusion/pull/15772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
berkaysynnada commented on code in PR #15772:
URL: https://github.com/apache/datafusion/pull/15772#discussion_r2073526461
##
datafusion/sql/src/query.rs:
##
@@ -168,7 +169,27 @@ pub(crate) fn to_order_by_exprs_with_select(
return not_impl_err!("ORDER BY INTERPOLATE is n
PokIsemaine commented on code in PR #15772:
URL: https://github.com/apache/datafusion/pull/15772#discussion_r2073503557
##
datafusion/sql/src/query.rs:
##
@@ -168,7 +169,27 @@ pub(crate) fn to_order_by_exprs_with_select(
return not_impl_err!("ORDER BY INTERPOLATE is not
berkaysynnada commented on code in PR #15772:
URL: https://github.com/apache/datafusion/pull/15772#discussion_r2073028935
##
datafusion/sql/src/query.rs:
##
@@ -168,7 +169,27 @@ pub(crate) fn to_order_by_exprs_with_select(
return not_impl_err!("ORDER BY INTERPOLATE is n
PokIsemaine commented on code in PR #15772:
URL: https://github.com/apache/datafusion/pull/15772#discussion_r2072647351
##
datafusion/sql/src/expr/order_by.rs:
##
@@ -61,13 +57,27 @@ impl SqlToRel<'_, S> {
None => input_schema,
};
-let mut expr_ve
xudong963 commented on code in PR #15772:
URL: https://github.com/apache/datafusion/pull/15772#discussion_r2072637962
##
datafusion/sql/src/expr/order_by.rs:
##
@@ -61,13 +57,27 @@ impl SqlToRel<'_, S> {
None => input_schema,
};
-let mut expr_vec
xudong963 commented on code in PR #15772:
URL: https://github.com/apache/datafusion/pull/15772#discussion_r2072637668
##
datafusion/sql/src/expr/order_by.rs:
##
@@ -61,13 +57,27 @@ impl SqlToRel<'_, S> {
None => input_schema,
};
-let mut expr_vec
PokIsemaine commented on code in PR #15772:
URL: https://github.com/apache/datafusion/pull/15772#discussion_r2070204781
##
datafusion/expr/src/expr.rs:
##
@@ -701,6 +701,24 @@ impl TryCast {
}
}
+/// OrderBy Expressions
+pub enum OrderByExprs {
+OrderByExprVec(Vec),
alamb commented on code in PR #15772:
URL: https://github.com/apache/datafusion/pull/15772#discussion_r2069775315
##
datafusion/expr/src/expr.rs:
##
@@ -701,6 +701,24 @@ impl TryCast {
}
}
+/// OrderBy Expressions
+pub enum OrderByExprs {
+OrderByExprVec(Vec),
+A
berkaysynnada commented on code in PR #15772:
URL: https://github.com/apache/datafusion/pull/15772#discussion_r2052112805
##
datafusion/expr/src/expr.rs:
##
@@ -701,6 +701,24 @@ impl TryCast {
}
}
+/// OrderBy Expressions
+pub enum OrderByExprs {
+OrderByExprVec(Vec)
PokIsemaine commented on code in PR #15772:
URL: https://github.com/apache/datafusion/pull/15772#discussion_r2051632953
##
datafusion/expr/src/expr.rs:
##
@@ -701,6 +701,24 @@ impl TryCast {
}
}
+/// OrderBy Expressions
+pub enum OrderByExprs {
+OrderByExprVec(Vec),
xudong963 commented on code in PR #15772:
URL: https://github.com/apache/datafusion/pull/15772#discussion_r2051496431
##
datafusion/expr/src/expr.rs:
##
@@ -701,6 +701,24 @@ impl TryCast {
}
}
+/// OrderBy Expressions
+pub enum OrderByExprs {
+OrderByExprVec(Vec),
+
PokIsemaine opened a new pull request, #15772:
URL: https://github.com/apache/datafusion/pull/15772
## Which issue does this PR close?
- None
## Rationale for this change
- https://github.com/apache/datafusion/issues/14514
## What changes are includ
14 matches
Mail list logo
