Re: [PR] feat: Add memory profiling [datafusion-comet]

2025-05-01 Thread via GitHub
kazuyukitanimura commented on code in PR #1702: URL: https://github.com/apache/datafusion-comet/pull/1702#discussion_r2070493011 ## spark/src/main/scala/org/apache/comet/CometExecIterator.scala: ## @@ -130,6 +134,21 @@ class CometExecIterator( def getNextBatch(): Option[Colum

Re: [PR] feat: Add memory profiling [datafusion-comet]

2025-05-01 Thread via GitHub
andygrove commented on code in PR #1702: URL: https://github.com/apache/datafusion-comet/pull/1702#discussion_r2070469650 ## native/core/src/execution/jni_api.rs: ## @@ -359,6 +365,21 @@ pub unsafe extern "system" fn Java_org_apache_comet_Native_executePlan( // Retriev

Re: [PR] feat: Add memory profiling [datafusion-comet]

2025-05-01 Thread via GitHub
comphead commented on code in PR #1702: URL: https://github.com/apache/datafusion-comet/pull/1702#discussion_r2070464759 ## native/core/src/execution/jni_api.rs: ## @@ -359,6 +365,21 @@ pub unsafe extern "system" fn Java_org_apache_comet_Native_executePlan( // Retrieve

Re: [PR] feat: Add memory profiling [datafusion-comet]

2025-05-01 Thread via GitHub
codecov-commenter commented on PR #1702: URL: https://github.com/apache/datafusion-comet/pull/1702#issuecomment-2845028742 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

Re: [PR] feat: Add memory profiling [datafusion-comet]

2025-05-01 Thread via GitHub
andygrove commented on PR #1702: URL: https://github.com/apache/datafusion-comet/pull/1702#issuecomment-2844943324 @mbutrovich I'd like to get your feedback on this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] feat: Add memory profiling [datafusion-comet]

2025-05-01 Thread via GitHub
andygrove opened a new pull request, #1702: URL: https://github.com/apache/datafusion-comet/pull/1702 ## Which issue does this PR close? Closes https://github.com/apache/datafusion-comet/issues/1701 ## Rationale for this change We need a way to profile mem