github-actions[bot] closed pull request #13404: feat: Add implicit casting to
`TypeSignature::String`
URL: https://github.com/apache/datafusion/pull/13404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
github-actions[bot] commented on PR #13404:
URL: https://github.com/apache/datafusion/pull/13404#issuecomment-2629725618
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
Omega359 commented on PR #13404:
URL: https://github.com/apache/datafusion/pull/13404#issuecomment-2517844638
[Here is
another](https://github.com/apache/datafusion/issues/13625#issuecomment-2517794438)
implicit casting behaviour that changed from 40 -> 43
--
This is an automated message
Omega359 commented on PR #13404:
URL: https://github.com/apache/datafusion/pull/13404#issuecomment-2507747026
> An alternative approach is that we need to differentiate `string literal`
and `varchar` like Postgres an DuckDB. Only untyped `string literal` is able to
cast to any other types,
Omega359 commented on PR #13404:
URL: https://github.com/apache/datafusion/pull/13404#issuecomment-2507744060
> @Omega359 How about we make this configurable? Enable implicit coercion if
we want the ease of use and the casting cost is acceptable, disable it if we
prefer explicit casting wit
jayzhan211 commented on PR #13404:
URL: https://github.com/apache/datafusion/pull/13404#issuecomment-2506916421
An alternative approach is that we need to differentiate `string literal`
and `varchar` like Postgres an DuckDB. Only untyped `string literal` is able to
cast to any other types,
jonathanc-n commented on PR #13404:
URL: https://github.com/apache/datafusion/pull/13404#issuecomment-2506910402
@jayzhan211 That sounds good. However, I think implicit coercion should be
the default or it'll cause regressions for users. Are you able to open this pr
back up, i can add the c
jayzhan211 commented on PR #13404:
URL: https://github.com/apache/datafusion/pull/13404#issuecomment-2506897643
And set implicit coercion as the default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jayzhan211 commented on PR #13404:
URL: https://github.com/apache/datafusion/pull/13404#issuecomment-2506894562
@Omega359
How about we make this configurable?
Enable implicit coercion if we want the ease of use and the casting cost is
acceptable, disable it if we want prefer explicit
Omega359 commented on PR #13404:
URL: https://github.com/apache/datafusion/pull/13404#issuecomment-2501784223
The regression I think was in 42.1.0 actually. I just built 42 off the tag
and ran it in docker:
```sql
root@f93d03a93bc1:/apache_datafusion# docker run --rm -it datafusion
alamb commented on PR #13404:
URL: https://github.com/apache/datafusion/pull/13404#issuecomment-2501734307
> Firstly, it's a regression from currently supported features and will
break things for users, myself included.
For this reason alone I agree , and it would definitely fall into
Omega359 commented on PR #13404:
URL: https://github.com/apache/datafusion/pull/13404#issuecomment-2501120749
I don't agree with the decision to not support implicit coercion to string
for function arguments.
Firstly, it's a regression from currently supported features and will break
jayzhan211 closed pull request #13404: feat: Add implicit casting to
`TypeSignature::String`
URL: https://github.com/apache/datafusion/pull/13404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jayzhan211 commented on PR #13404:
URL: https://github.com/apache/datafusion/pull/13404#issuecomment-2499346571
> @jayzhan211 So should this PR be closed? Since there is no need for
implicit casting in TypeSignature::String? I just worked on this because of
your comment on implicit casting
jonathanc-n commented on PR #13404:
URL: https://github.com/apache/datafusion/pull/13404#issuecomment-2499318140
@jayzhan211 So should this PR be closed? Since there is no need for implicit
casting in TypeSignature::String? I just worked on this because of your comment
on implicit casting i
jayzhan211 commented on PR #13404:
URL: https://github.com/apache/datafusion/pull/13404#issuecomment-2499306321
> this behaviour seems to have been deprecated in DuckDB.
Did they deprecate?
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
jonathanc-n commented on PR #13404:
URL: https://github.com/apache/datafusion/pull/13404#issuecomment-2499212644
@alamb @jayzhan211 I'm a bit confused with this pr, are we looking to
support implicit casting with TypeSignature or not? As can be seen above, this
behaviour seems to have been
jayzhan211 commented on PR #13404:
URL: https://github.com/apache/datafusion/pull/13404#issuecomment-2484777222
Mark this as draft as it is not ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
jayzhan211 commented on code in PR #13404:
URL: https://github.com/apache/datafusion/pull/13404#discussion_r1843017667
##
datafusion/sqllogictest/test_files/expr.slt:
##
@@ -510,6 +510,42 @@ SELECT ltrim(NULL, 'xyz')
NULL
+# implicit casting with TypeSignature test
+que
jayzhan211 commented on code in PR #13404:
URL: https://github.com/apache/datafusion/pull/13404#discussion_r1843017667
##
datafusion/sqllogictest/test_files/expr.slt:
##
@@ -510,6 +510,42 @@ SELECT ltrim(NULL, 'xyz')
NULL
+# implicit casting with TypeSignature test
+que
jonathanc-n commented on PR #13404:
URL: https://github.com/apache/datafusion/pull/13404#issuecomment-247522
Will fix this tommorow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
Omega359 commented on PR #13404:
URL: https://github.com/apache/datafusion/pull/13404#issuecomment-2475304795
Please remove the changes to regexp_match as that change adds in support for
utf8view which breaks that function (see ci output). It's a much larger issue
than those changes. See
h
jonathanc-n opened a new pull request, #13404:
URL: https://github.com/apache/datafusion/pull/13404
## Which issue does this PR close?
Closes #.
## Rationale for this change
#13402 #13394 were running into some problems with implicit casting due to
TypeSignature::Str
23 matches
Mail list logo
