alamb commented on PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#issuecomment-2945964478
gogogo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
alamb merged PR #14775:
URL: https://github.com/apache/datafusion/pull/14775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#issuecomment-2945762124
It seems github is experiencing issues. I will close/reopen this PR to
restart the checks
https://www.githubstatus.com/
https://github.com/user-attachments/assets/2bc627ef
timsaucer opened a new pull request, #14775:
URL: https://github.com/apache/datafusion/pull/14775
## Which issue does this PR close?
This PR addresses part of #14562
## Rationale for this change
This change allows for using user defined **aggregate** functions across FFI
alamb closed pull request #14775: feat: Add Aggregate UDF to FFI crate
URL: https://github.com/apache/datafusion/pull/14775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
alamb commented on PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#issuecomment-2945599542
I merged up one more time to make sure the CI tests pass but assuming they
do I plan to merge this one in
--
This is an automated message from the Apache Git Service.
To respond to t
alamb commented on PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#issuecomment-2945576944
Thank you very much @m09526 for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
timsaucer commented on PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#issuecomment-2941554545
@alamb I believe this one is ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
timsaucer commented on code in PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#discussion_r2127109672
##
datafusion/ffi/src/arrow_wrappers.rs:
##
@@ -31,30 +32,37 @@ use log::error;
#[derive(Debug, StableAbi)]
pub struct WrappedSchema(#[sabi(unsafe_opaque_field
timsaucer commented on code in PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#discussion_r2127291948
##
datafusion/ffi/src/arrow_wrappers.rs:
##
@@ -31,30 +32,37 @@ use log::error;
#[derive(Debug, StableAbi)]
pub struct WrappedSchema(#[sabi(unsafe_opaque_field
timsaucer commented on code in PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#discussion_r2127109672
##
datafusion/ffi/src/arrow_wrappers.rs:
##
@@ -31,30 +32,37 @@ use log::error;
#[derive(Debug, StableAbi)]
pub struct WrappedSchema(#[sabi(unsafe_opaque_field
alamb commented on code in PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#discussion_r2078483270
##
datafusion/ffi/src/arrow_wrappers.rs:
##
@@ -31,30 +32,37 @@ use log::error;
#[derive(Debug, StableAbi)]
pub struct WrappedSchema(#[sabi(unsafe_opaque_field)] p
timsaucer commented on code in PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#discussion_r2037099896
##
datafusion/ffi/src/udaf/groups_accumulator.rs:
##
@@ -0,0 +1,527 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
timsaucer commented on PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#issuecomment-2792396725
@robtandy As someone keenly interested in the FFI work, would you be able to
do a review?
--
This is an automated message from the Apache Git Service.
To respond to the message,
crystalxyz commented on code in PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#discussion_r2034322874
##
datafusion/ffi/src/arrow_wrappers.rs:
##
@@ -31,30 +32,37 @@ use log::error;
#[derive(Debug, StableAbi)]
pub struct WrappedSchema(#[sabi(unsafe_opaque_fiel
crystalxyz commented on PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#issuecomment-2788095551
@timsaucer @alamb Should be good for review now. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
crystalxyz commented on code in PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#discussion_r2034322874
##
datafusion/ffi/src/arrow_wrappers.rs:
##
@@ -31,30 +32,37 @@ use log::error;
#[derive(Debug, StableAbi)]
pub struct WrappedSchema(#[sabi(unsafe_opaque_fiel
crystalxyz commented on PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#issuecomment-2787442786
> > Now that #15487 is resolved, this is unblocked.
>
> Shall we mark it as "ready for review"?
@alamb I'm helping Tim on this and I'm still addressing some comments.
alamb commented on PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#issuecomment-2783244753
> Now that #15487 is resolved, this is unblocked.
Shall we mark it as "ready for review"?
--
This is an automated message from the Apache Git Service.
To respond to the message
CrystalZhou0529 commented on code in PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#discussion_r2023878333
##
datafusion/ffi/tests/ffi_integration.rs:
##
@@ -179,4 +181,103 @@ mod tests {
Ok(())
}
+
+#[tokio::test]
+async fn test_ffi_udaf
timsaucer commented on PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#issuecomment-2766341477
Now that https://github.com/apache/datafusion/pull/15487 is resolved, this
is unblocked.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
timsaucer commented on PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#issuecomment-2718834645
The above `Nullary` issue also impacts the existing Scalar UDFs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
timsaucer commented on PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#issuecomment-2718834031
Moved to draft until I get time to address the comments above. Additionally
I discovered that `Nullary` type signatures do not make it properly through the
type coercion, so that n
alamb commented on PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#issuecomment-2718345177
Let me know when this is ready for review:
https://github.com/apache/datafusion/pull/14775
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
timsaucer commented on PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#issuecomment-2692686473
@m09526 Thank you for the review! I've been out of country all last week, so
I will try to get back to this soon now that I'm back.
--
This is an automated message from the Apach
m09526 commented on code in PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#discussion_r1975307949
##
datafusion/ffi/src/arrow_wrappers.rs:
##
@@ -31,30 +32,37 @@ use log::error;
#[derive(Debug, StableAbi)]
pub struct WrappedSchema(#[sabi(unsafe_opaque_field)]
timsaucer commented on code in PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#discussion_r1974316424
##
datafusion/ffi/src/tests/udf_udaf_udwf.rs:
##
@@ -25,3 +29,15 @@ pub(crate) extern "C" fn create_ffi_abs_func() ->
FFI_ScalarUDF {
udf.into()
}
+
+pu
Omega359 commented on code in PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#discussion_r1974186012
##
datafusion/ffi/src/tests/udf_udaf_udwf.rs:
##
@@ -25,3 +29,15 @@ pub(crate) extern "C" fn create_ffi_abs_func() ->
FFI_ScalarUDF {
udf.into()
}
+
+pub
28 matches
Mail list logo
