Re: [PR] feat(spark): implement Spark math function rint [datafusion]

2025-07-30 Thread via GitHub
alamb commented on PR #16924: URL: https://github.com/apache/datafusion/pull/16924#issuecomment-3137696420 Thanks @chenkovsky and @comphead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] feat(spark): implement Spark math function rint [datafusion]

2025-07-30 Thread via GitHub
alamb merged PR #16924: URL: https://github.com/apache/datafusion/pull/16924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] feat(spark): implement Spark math function rint [datafusion]

2025-07-29 Thread via GitHub
comphead commented on code in PR #16924: URL: https://github.com/apache/datafusion/pull/16924#discussion_r224013 ## datafusion/spark/src/function/math/rint.rs: ## @@ -0,0 +1,161 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

Re: [PR] feat(spark): implement Spark math function rint [datafusion]

2025-07-29 Thread via GitHub
chenkovsky commented on code in PR #16924: URL: https://github.com/apache/datafusion/pull/16924#discussion_r2239370817 ## datafusion/spark/src/function/math/rint.rs: ## @@ -0,0 +1,162 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licen

Re: [PR] feat(spark): implement Spark math function rint [datafusion]

2025-07-29 Thread via GitHub
chenkovsky commented on code in PR #16924: URL: https://github.com/apache/datafusion/pull/16924#discussion_r2239370817 ## datafusion/spark/src/function/math/rint.rs: ## @@ -0,0 +1,162 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licen

Re: [PR] feat(spark): implement Spark math function rint [datafusion]

2025-07-29 Thread via GitHub
shehabgamin commented on code in PR #16924: URL: https://github.com/apache/datafusion/pull/16924#discussion_r2239266847 ## datafusion/spark/src/function/math/rint.rs: ## @@ -0,0 +1,162 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] feat(spark): implement Spark math function rint [datafusion]

2025-07-27 Thread via GitHub
alamb commented on PR #16924: URL: https://github.com/apache/datafusion/pull/16924#issuecomment-3124419443 Thank you for driving this @chenkovsky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] feat(spark): implement Spark math function rint [datafusion]

2025-07-26 Thread via GitHub
chenkovsky opened a new pull request, #16924: URL: https://github.com/apache/datafusion/pull/16924 ## Which issue does this PR close? - Closes #. ## Rationale for this change ## What changes are included in this PR? implement spark rint udf ## Are these cha