alamb commented on PR #13786:
URL: https://github.com/apache/datafusion/pull/13786#issuecomment-2557716605
Thanks again @rluvaton @Omega359 and @2010YOUY01 :rockeet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
alamb merged PR #13786:
URL: https://github.com/apache/datafusion/pull/13786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
rluvaton commented on PR #13786:
URL: https://github.com/apache/datafusion/pull/13786#issuecomment-2557051641
So I merged both implementations into one, I don't really like it, the
naming I choose is off, I need a better name but all comments and resolved
--
This is an automated message f
rluvaton commented on code in PR #13786:
URL: https://github.com/apache/datafusion/pull/13786#discussion_r1893959873
##
datafusion/functions/src/core/least.rs:
##
@@ -0,0 +1,283 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
rluvaton commented on code in PR #13786:
URL: https://github.com/apache/datafusion/pull/13786#discussion_r1893959616
##
datafusion/functions/src/core/least.rs:
##
@@ -0,0 +1,283 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
rluvaton commented on code in PR #13786:
URL: https://github.com/apache/datafusion/pull/13786#discussion_r1893959228
##
datafusion/functions/src/core/least.rs:
##
@@ -0,0 +1,283 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
rluvaton commented on PR #13786:
URL: https://github.com/apache/datafusion/pull/13786#issuecomment-2553743042
Thank you, I did not have time to update based on the review, I'll do it in
the coming days
--
This is an automated message from the Apache Git Service.
To respond to the message,
alamb commented on code in PR #13786:
URL: https://github.com/apache/datafusion/pull/13786#discussion_r1891888338
##
datafusion/functions/src/core/least.rs:
##
@@ -0,0 +1,283 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
2010YOUY01 commented on code in PR #13786:
URL: https://github.com/apache/datafusion/pull/13786#discussion_r1885676215
##
datafusion/functions/src/core/least.rs:
##
@@ -0,0 +1,283 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license a
korowa commented on PR #13786:
URL: https://github.com/apache/datafusion/pull/13786#issuecomment-2543849481
Thank you @rluvaton
Taking into account that the least/greatest implementations are almost
identical (the way how these functions handle input arguments / constant
folding opti
Omega359 commented on PR #13786:
URL: https://github.com/apache/datafusion/pull/13786#issuecomment-2543367795
LGTM. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Omega359 commented on code in PR #13786:
URL: https://github.com/apache/datafusion/pull/13786#discussion_r1885413349
##
datafusion/functions/src/core/least.rs:
##
@@ -0,0 +1,283 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
rluvaton commented on code in PR #13786:
URL: https://github.com/apache/datafusion/pull/13786#discussion_r1885350394
##
datafusion/functions/src/core/least.rs:
##
@@ -0,0 +1,283 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
rluvaton opened a new pull request, #13786:
URL: https://github.com/apache/datafusion/pull/13786
## Which issue does this PR close?
Closes #6531
## Rationale for this change
adding more expressions support, and I already added `greatest`
## What changes are include
14 matches
Mail list logo
